From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /S61B0aYwWdwtAAAWB0awg (envelope-from ) for ; Fri, 28 Feb 2025 06:04:38 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=T3vS/wSX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0DD3E1E105; Fri, 28 Feb 2025 06:04:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 72F281E08E for ; Fri, 28 Feb 2025 06:04:37 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DAB033858C30 for ; Fri, 28 Feb 2025 11:04:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DAB033858C30 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=T3vS/wSX Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 5A5DF3858C51 for ; Fri, 28 Feb 2025 11:03:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5A5DF3858C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5A5DF3858C51 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1740740624; cv=none; b=LrvVLQ4zK5d/W+JSlv07o8iJsVIxLznHBWiMZo6l+R1WTxM05ej7XKEEsIBUQjG/eibvj+yBGbLIm9DGNaCtaWlkw7OgIMS53etZETRDwkrSeiTQXTai/qR16iV7+nUMCaEP6qd975OL2edWAkAGtt+8a2ZXKpL5mTc1iu0oRnU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1740740624; c=relaxed/simple; bh=5pK2PreHqPMHbRB/EMqw1iFAaClcKNnP9oU73g8k6sI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WwWPZ3B/x8ltoYJ2MjW9/ndhDic+sOeL6FpNWWpRcizM5D9AGqfybwmKfK5vZZbwOXN+dVyDSVoXmVO6fh2akrkbt8mmD/ETfJZU+pwYsxgqqt3+lo8C5GTfm4p1jn8Eu7Qt8SbrO9GEuxDHlTkplNbMk1HukyCqdXuMGu7dqvE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5A5DF3858C51 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740740624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U991lHQA5K37/drUb6Ib8zTk90iK1vOP8X5lR0dOJ2w=; b=T3vS/wSX3Nr6vyhnPVrFUxjxX6hEZPo46flPD7vgjdqOTxz/KzThbwyqtuW3VIrXa3/aXa Ot+BnAgPmaS3GW713/SOYeS4ZQDsQopW6vZdQ+Ti8eByz31h5RGKoeIApnlPWkcZfHu3WJ t1HwRYvxB8qACLppTKlm148PruX2pEE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-LGYnzUDtM1KAixtNV-0_ig-1; Fri, 28 Feb 2025 06:03:42 -0500 X-MC-Unique: LGYnzUDtM1KAixtNV-0_ig-1 X-Mimecast-MFC-AGG-ID: LGYnzUDtM1KAixtNV-0_ig_1740740622 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38f338525e1so806220f8f.3 for ; Fri, 28 Feb 2025 03:03:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740740621; x=1741345421; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U991lHQA5K37/drUb6Ib8zTk90iK1vOP8X5lR0dOJ2w=; b=tgjGrMXnE4swdGRBznWZCCpV0TbU/iZQ4LdKzghYESEd7q18gLu2P1dWQP7qjFCcBm ECDDgcIybDVMVrOc+omb06nHogV6Hsws5Yj/ib0R+oyQi7lhyfFTj+o7DAI2b7s5UjNn W8SMLtgW/j8dmLpBAo+g9vjJQZowz7zbLz6d6uYD2+TrF1Te2n8rneAjZYvCR6vczRAN xNLmVGgbLETXahfhkoZxKwDGPjyWx2fJGv/1xCdZm1LY62GbgSarIEY1wDJsv/NNDkfu gPiqnHJWiv500jzXwWbn8MVqH1VOlYGifavQ30WMxQTgTbS0ny3aUrYMCMbCHgUsjcq+ nlnw== X-Gm-Message-State: AOJu0Yzb7ZzZd3kjtWekhcxWA53seHbmsG4p4l38lbGO05ueo4Tc63UA q+dzfAeUUbzoyMZgeqUtsn1GNLpTFj25Oj/civJFkX6QD6sx1yAZX1R2l5vZB/FMmuQSdmhevaa Qh/QPxJTZahl9KH3gygaH1A76Bq2WEt/93NIMwFrT3a8/TL+IilLQhPTfdrVkh3sqDi0= X-Gm-Gg: ASbGnctz2SPeStfgmFkYj7Hu1xCReQIxb3y/cKR+GrYUZYXfjZ8oTqgJkEZN1d7nI99 1f2eSX5wNpzfXuKcoeC6AIENt6RVwST+0czSLjX9rL5MWbTK/xXd5TOSdiW5V7Qn/NYkeeZC4qH Z1sVrsd/2neRkEL/D0VDAelhODLFhSPuiDl5aqQRj9tkgEetCAEsbaBDiQtt1BebkL7udGHyMmg wP4TNpljTh3fSeEs2Adc73iZlEIqQUO0ySf0OX9DzlYG+vWXqdPdY9mR+o+glpqSwPsKAkn+ICz cCxbtGkh9EntzeRr+Ojmrh6PUjUVH46OckCzgyOB X-Received: by 2002:a05:6000:4029:b0:38f:3e39:20ae with SMTP id ffacd0b85a97d-390eca07053mr2723980f8f.43.1740740620973; Fri, 28 Feb 2025 03:03:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuOUlD2VBK+HXFQV5IpAL7R1E7dDaUTGRb8lbCja9OhbcqKn6PkJMnhRcLwN+UJIada2v+eQ== X-Received: by 2002:a05:6000:4029:b0:38f:3e39:20ae with SMTP id ffacd0b85a97d-390eca07053mr2723949f8f.43.1740740620633; Fri, 28 Feb 2025 03:03:40 -0800 (PST) Received: from localhost (44.226.159.143.dyn.plus.net. [143.159.226.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e4795d44sm4810623f8f.8.2025.02.28.03.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 03:03:40 -0800 (PST) From: Andrew Burgess To: Brandon Belew Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] [PR corefiles/32441] Fix segfault if target_fileio_read_alloc fails In-Reply-To: References: <87v7ueog73.fsf@redhat.com> Date: Fri, 28 Feb 2025 11:03:39 +0000 Message-ID: <87ikouz5ys.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jrKBWsdSGlzVQKTk5jRXBekdXtxdJV_EDALg-17vARM_1740740622 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Brandon Belew writes: > Check for target_fileio_read_alloc failure in linux_fill_prpsinfo > before dereferencing buffer. This fixes a segfault in the 'gcore' > command when attached to certain remote targets. LGTM. Approved-By: Andrew Burgess Thanks, Andrew > --- > gdb/linux-tdep.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c > index d3ab02d03e0..735d20dc050 100644 > --- a/gdb/linux-tdep.c > +++ b/gdb/linux-tdep.c > @@ -854,7 +854,7 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args, > { > xsnprintf (filename, sizeof filename, "/proc/%ld/cmdline", pid); > gdb_byte *buffer; > - ssize_t len = target_fileio_read_alloc (NULL, filename, &buffer); > + LONGEST len = target_fileio_read_alloc (nullptr, filename, &buffer); > > if (len > 0) > { > @@ -2180,17 +2180,17 @@ linux_fill_prpsinfo (struct elf_internal_linux_prpsinfo *p) > /* The number of fields read by `sscanf'. */ > int n_fields = 0; > > - gdb_assert (p != NULL); > + gdb_assert (p != nullptr); > > /* Obtaining PID and filename. */ > pid = inferior_ptid.pid (); > xsnprintf (filename, sizeof (filename), "/proc/%d/cmdline", (int) pid); > /* The full name of the program which generated the corefile. */ > - gdb_byte *buf = NULL; > - size_t buf_len = target_fileio_read_alloc (NULL, filename, &buf); > + gdb_byte *buf = nullptr; > + LONGEST buf_len = target_fileio_read_alloc (nullptr, filename, &buf); > gdb::unique_xmalloc_ptr fname ((char *)buf); > > - if (buf_len < 1 || fname.get ()[0] == '\0') > + if (buf_len < 1 || fname.get () == nullptr || fname.get ()[0] == '\0') > { > /* No program name was read, so we won't be able to retrieve more > information about the process. */ > -- > 2.47.1