From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cRmgCHt4wGjvCT4AWB0awg (envelope-from ) for ; Tue, 09 Sep 2025 14:56:59 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=RUZqbXLd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1D3311E0BA; Tue, 09 Sep 2025 14:56:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AC6D61E04C for ; Tue, 09 Sep 2025 14:56:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2056E3858C54 for ; Tue, 9 Sep 2025 18:56:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2056E3858C54 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=RUZqbXLd Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id BFEAC3858C2A for ; Tue, 9 Sep 2025 18:55:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BFEAC3858C2A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BFEAC3858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757444130; cv=none; b=jcS1akdi34ZdWGxjFqvyzK+/oZCnaEA0xpOGwJU81VVZo9J1pItWOuZLQ2nugIXRp9WdQMA6yZ3MNBZXnYsk7Ay46oZeIW1B9f6nByqon2RcZ8n+w6Kl+yZxvgXI/oYGRyFP/iLdQp2c0Rx2RpxECaRwxzaopuu9dbc1GQYnFbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757444130; c=relaxed/simple; bh=LVVw+vFUqvjjtX6WBJ5Hx9M/OYm6YUDVCka1u2a3ZJ0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SQVVLsSGk+ZzKEmpMRIufpwgaVCT8z1Jan2ZGkNRe4c+Dhmip+dKeI1RxqSYvY/mgWcud1eOOM4TYPcIcdsleQNocdDD6nmIDWDkf/dvtyXFXFxiPuMcOVrOlzBdq/L43NeayzsC8mAg4B0p8fIh/tXeAWP/Z9d2SCEVQqts1L8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BFEAC3858C2A Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-8876de33c86so363026239f.3 for ; Tue, 09 Sep 2025 11:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1757444129; x=1758048929; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Yyi7cBBcN4EM9656Ce33MIDQg05X+R4MC7k902m8450=; b=RUZqbXLdBizNOJHCz2tyXsNWwcRfb7prIp8pR5CzScnUjUTa/snh0ofW7pjFUK3sdX 2TnNdHeKBp3qihOX81sgiWunhWHCLynxLTHvftFB494DAMUFuRpAjYHNRn8SauFJSTDm dvaRos1ovPrWo1Mx2vEJ1tashPq24J0IxSLl+3OtRFoVFSv85G1+ZjAdFsDnixrXM3p4 ajkeG6pjeRoSfNr/5KvTxw0niwgjHy51X+2vjlfyHQaqCaDhCBJN8DfvMhZu81Fbg25L VEGRfdZNx1PN0kTRHOpT+GdXG9tNCHZ1Bs2wOlb+LncF5RdQsPJRgbP25nXulnVp1Q/m ISSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757444129; x=1758048929; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Yyi7cBBcN4EM9656Ce33MIDQg05X+R4MC7k902m8450=; b=gVvs3O+ykOyjvXY2yqnZm7N+ER08+VRljuSC32vQq/rHlzk+/eXLqm8q+M/8wuMO64 o+on/UJSl0JW8W80MoOZz81uJUgf05RRjxLRReia/QBszWB2JFR6+1SEOpzVoeiH9LEC KeONilx5HD3C0nQhHj1gVdxrCvKEhDLrVsot756Ye8nAh6eL4bnqaubt1wXNVHs5dEgJ hgRhSUM6q4gTFwaNF8JC2SlFtEfwuIm9w+nhNuRM1v0idmJUPI+7rrjP6p6iUtcifDCZ cBNd/ZalRIqRmzyltK5ixymWoUFQMOSZeWKEZayop0sM1zeM/BVj4KawRF3MTimAUau0 t4KA== X-Forwarded-Encrypted: i=1; AJvYcCX7RnZfV85vt4Lu/uaPplVa59YnE+EEE1101GBepxoNyDQSKbcvu++UTCIslGpNd7GJ6s59HHkPKeGjFg==@sourceware.org X-Gm-Message-State: AOJu0Yzu3lTz5HbXGjZXdfG6V4+Y7VNvw1rzVPupLsiL4gzl5U8I6myQ AroxbOmlpk5j77pFrIFAbTiu67O2Y9j8KGae3xqDJQ0K4Cj5vwBYgNbXrMIHujw4O/b3cZaOLTx AWck= X-Gm-Gg: ASbGncvZaQ8eg00dZ8xdcwLf0Qx55PjaTGirhLi/MO8rC807Z79qFscgPtFKAiRjX81 8qUb99YkvWX/zydZXxpb1V6cq3ewHR3M8cS3X6lflXnw9x6qt996mYFzMfq9XIUqFY86ePuNBak lwrNxN5SmmZv0GXUvaF2tXsI8TEE9riHbahP/Fz/WjVOrH5woQhFMC0MblMAW8MlKt/3UMvLXbB GagRZXBK6C4ctJnj3CiT8DUyKQXdkQx6ae39SegALIPES+skLV1q+YwGzKj+yB1fEDMEMOa8r3T SUFM4tfnd8moc/iFgqWqOH5eF9+5/by9LNmHkUGdCHgesp41VBb8KHD5Trwd/lF/1TtMXkO8uTB reJizzNiuVGRJjcUj1aTH9R8g/m0V+KKwpZHdZfRGDnMLhflCdcpw X-Google-Smtp-Source: AGHT+IEzpC4UUzSfSdcOtoNg3f0b3C7YlcAHTKI/vWnuZD+gul+J/ZNl5eK4Fcq9WQy41lNbIrMcwA== X-Received: by 2002:a05:6e02:1607:b0:3f3:dd9a:63d6 with SMTP id e9e14a558f8ab-3fd961f424amr196944125ab.22.1757444128881; Tue, 09 Sep 2025 11:55:28 -0700 (PDT) Received: from bapiya (97-122-110-68.hlrn.qwest.net. [97.122.110.68]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-4154b05d2d8sm2508355ab.16.2025.09.09.11.55.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 11:55:28 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Use gnulib c-ctype module, not In-Reply-To: <3208ce09-e47c-4355-898e-321891a26558@simark.ca> (Simon Marchi's message of "Tue, 9 Sep 2025 14:01:42 -0400") References: <20250806-gnulib-c-ctype-v1-0-10f33e9f22a4@adacore.com> <87h5yiq32b.fsf@tromey.com> <87qzwfpl62.fsf@tromey.com> <3208ce09-e47c-4355-898e-321891a26558@simark.ca> X-Attribution: Tom Date: Tue, 09 Sep 2025 12:55:27 -0600 Message-ID: <87ikhrpiao.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> Just as a reminder to everyone, gdb should generally use these new >> "c-ctype" wrapper functions and not . >> >> One idea I had for enforcement was to write a new pre-commit script that >> looked for includes of ctype.h or safe-ctype.h. WDYT? Simon> 1. Should all includes of ctype.h and safe-ctype.h be removed from GDB Simon> right now, in any case? Yeah, this series did that. Simon> 2. Is ctype.h available transitively anyway? If so, we could add a Simon> call to a ctype.h function without adding an include, so the script Simon> wouldn't catch it. That's true, it's available sometimes depending on which libstdc++ headers are included. Tom