From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kNcBHXCTzWg5uAoAWB0awg (envelope-from ) for ; Fri, 19 Sep 2025 13:31:28 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Dbbx03Wj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 64A1A1E04C; Fri, 19 Sep 2025 13:31:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C9A461E04C for ; Fri, 19 Sep 2025 13:31:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D1093858408 for ; Fri, 19 Sep 2025 17:31:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D1093858408 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Dbbx03Wj Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id C55D73858D21 for ; Fri, 19 Sep 2025 17:30:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C55D73858D21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C55D73858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758303033; cv=none; b=MzVJDFtZX7NlZiIBg6ccYc8qzNVlwvz9GNx6bXj047sQKtWlhq6NQom4cptzz6ofarKSnBfOJPISx2PYbPpWDNlc8lnfCsulWwR95G/CQm3kbJrwe6aI5mB0ZqNmfGd/kqLYmOqO0ximCtNuPIPah8R6BdPCAPFZETZnCBlmMgk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758303033; c=relaxed/simple; bh=PytUG3IEuqAoMgikp+u+kSQ6mPlfFJ/xTOYr+kGEsWM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lZ/OtP9P5X0bwhnbvbNnokneu4dPwwkc1fScOuNPc97US8lHozpjE3T0DjwFVGqYZVaBT8pR/jj+evqgxv41F7wx9PfKBGDPiPsYbCletOwKCgb8uqwrQOZ5DRzeOiwrKgPEf7GaXDdKw+cl7XDteICfocaQFtMmukuH/5nCTSQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C55D73858D21 Received: from eig-obgw-6001b.ext.cloudfilter.net ([10.0.30.143]) by cmsmtp with ESMTPS id ze1mu2CbbLIlMzewKuEVrO; Fri, 19 Sep 2025 17:30:32 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zewJuRJFGDV65zewJuQj0l; Fri, 19 Sep 2025 17:30:31 +0000 X-Authority-Analysis: v=2.4 cv=dLammPZb c=1 sm=1 tr=0 ts=68cd9338 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=mMcYH3Q2zFQEFZZkRyAA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=u0T+XW8JE3h2gMllg9Wydbs3f3oXmK9cLWmPzaJgfO8=; b=Dbbx03WjBGkuqPK1s1iTEqpeC6 XBF4D4KvUIBGWJ6Xam9yuNB7TdO7ZmXZ9VC3o5k9b5BHSv2foVKsIQRTiHWqX26y9jKEfm3j6s+tP y1CQfQk1wa/njXeEkzSxijN+x; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:51338 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uzewJ-00000001C1n-0Inb; Fri, 19 Sep 2025 11:30:31 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] [gdb/symtab] Fix DW_TAG_member regression In-Reply-To: <20250915153334.18723-1-tdevries@suse.de> (Tom de Vries's message of "Mon, 15 Sep 2025 17:33:34 +0200") References: <20250915153334.18723-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 19 Sep 2025 11:30:30 -0600 Message-ID: <87ikhee4eh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uzewJ-00000001C1n-0Inb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:51338 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKCyhKo8EeueRu+mFKUqQP9DEAbkA8R/De/suRpdXpJRqJ8gNMk+YiUqUm+sTyv74L/Fi3zaqcy/Emkcl5l1c5/LPkoIO5m5XGBtovkglCE93od4L4Rv C2M+tEPahTSGwltFZfS5rEELYFEMdhYuIaWmNRlOBgsO/QemhxzqDg0zej1SpByiwGaeWnXc/BiNR76/rjUkaVDutlnuTN2D3Yw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom> + else if (cur_abbrev->tag == DW_TAG_member && has_const_value Tom> + && has_external) I'm a little surprised by this test. I guess I would assume we'd see this same problem for a static class variable even if it doesn't have an initializer. And I'm not sure has_external is needed? I would have expected something like "has const value or has a location" instead. Could Tom> + { Tom> + /* For Dwarf v4, GCC generates a DW_TAG_member for a static const Tom> + member. */ ... but OTOH if this is the only case where DW_TAG_member is generated then it seems fine. Though I still don't understand the "external" bit. So if this is correct could you add some explanation for it? Tom> --- a/gdb/dwarf2/cooked-index-shard.c Tom> +++ b/gdb/dwarf2/cooked-index-shard.c Tom> @@ -65,6 +65,15 @@ cooked_index_shard::create (sect_offset die_offset, Tom> else if (tag_is_type (tag)) Tom> flags |= IS_STATIC; Tom> + if (tag == DW_TAG_member) Tom> + { Tom> + /* A cooked index entry generated for a DW_TAG_member should be treated Tom> + the same as one generated for a DW_TAG_variable. Normalize to Tom> + DW_TAG_variable, to simplify code dealing with cooked index Tom> + entries. */ Tom> + tag = DW_TAG_variable; Tom> + } I think this should be in the scanner and not here. Tom