From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 22gOIi8iL2kPExEAWB0awg (envelope-from ) for ; Tue, 02 Dec 2025 12:30:23 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=JJfeslUh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 714C41E08D; Tue, 02 Dec 2025 12:30:23 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EFB271E08D for ; Tue, 02 Dec 2025 12:30:22 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7B9DC4BC89A3 for ; Tue, 2 Dec 2025 17:30:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7B9DC4BC89A3 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=JJfeslUh Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 383074BA23F0 for ; Tue, 2 Dec 2025 17:29:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 383074BA23F0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 383074BA23F0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764696595; cv=none; b=NmngBKvMDBryqAtC0HiwnBFKvgH5D2LsTkN3Qyg0WtijVZsgezoklqxlivUWHdLX4dnbN2k9QVBsMDZJfMPJ156RTktwY/XaGrADZ6W6WZqjWTrKdd0obR/D6Vq3S/xdBkOC2s9A7vyuZ1Fu2XDaLXkRxEYx8zZMDpiqhfwZYSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764696595; c=relaxed/simple; bh=tE2EjttiOKV8vnGu8Uzhlh2XV6YJRVAkO2xtEPGsSMo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GN3ODDvCAXjR6ZSmEHJqWlijjw9y0M5SEBOAKsBTlfsIhlaqwkUKQjZMd34PEKCQMdMrFUHEoykq1J9X1VPfcMUiq17kKRu1nR8z0e+VdVrHivqzFWbfuVUjBMNo7D8vqQaO/hv+vwvUgxqi7Piy2CYrUewxjROEhw7tCXoqvHE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 383074BA23F0 Received: from eig-obgw-6004b.ext.cloudfilter.net ([10.0.30.210]) by cmsmtp with ESMTPS id QRy8vscsZaPqLQUCIvoMsU; Tue, 02 Dec 2025 17:29:54 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QUCHvwEJVK8vzQUCHvJQGA; Tue, 02 Dec 2025 17:29:53 +0000 X-Authority-Analysis: v=2.4 cv=cJDgskeN c=1 sm=1 tr=0 ts=692f2211 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=wP3pNCr1ah4A:10 a=ItBw4LHWJt0A:10 a=TDl5R864AAAA:8 a=eydj0nl7XRQ6HNP2f6gA:9 a=4IKI_MBedZsHOhguCAbN:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pj3D54f2gKniIhxz+r5evlNH+M8oHRRxgMv982k7XJo=; b=JJfeslUh5EytVe4Fxf2P8odmKD Qx9Y3df+XvLMW2rr9oc1WZBoFvAQdNF46u0REXqKA5N2kprUh3WmpchBc7yfP8I830VFQJMdFOLzY GJZ+6czTq4257bNYqxGiWaerP; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:34778 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vQUCH-00000001qVD-0pku; Tue, 02 Dec 2025 10:29:53 -0700 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 13/13] gdb: update message in symbol_file_add_with_addrs after changes in readnow_functions In-Reply-To: <20251124195535.2116845-14-jan.vrany@labware.com> (Jan Vrany's message of "Mon, 24 Nov 2025 19:55:35 +0000") References: <20251124195535.2116845-1-jan.vrany@labware.com> <20251124195535.2116845-14-jan.vrany@labware.com> X-Attribution: Tom Date: Tue, 02 Dec 2025 10:29:52 -0700 Message-ID: <87ikeo94hb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vQUCH-00000001qVD-0pku X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:34778 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDlvQoGyHMZrPtp5ejygGJ4vhUXi2CqARr7+QiuChAY7hwW2xOv3k8+8uktxJ4AJrpSMgOSVdzhGQ2ycpNMpGj8vI0zxjppeE0VE1+njVvEI9qR4YKzt gzmYlGWEmh9FN/gsiyiPZfFjhnaEznWgYxLkDbxf+4o16sF5LKasptuO1eCemcRvmhBR5Aqgzw7XJoUSoaKcLhFepUubr+ke3Zs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Jan" == Jan Vrany writes: Jan> When loading a file with -readnow, GDB prints message like: Jan> Reading symbols from some_program... Jan> Expanding full symbols from some_program... Jan> I assume the reason for the second message ("Expanding ...") is to let Jan> the user know what's happening as symbol expansion may take time. Yeah. I wonder if instead of rewriting expand_all_symtabs in this series, you could leave most of that patch in place but still have readnow_functions::expand_all_symtabs actually do the work. Then when/if readnow_functions is moved out of the DWARF reader, the DWARF reader could subclass it to just add the one new method. This way the message would still arrive at the right time, which seems friendlier to users. Jan> This commit therefore checks if there are any unexpanded CUs and if Jan> so, prints "Expanding full..." message as before. If all CUs are already Jan> expanded, say just "Expanded full...". Also if there are multiple debug readers for an objfile, we could get the "wrong" message here through no fault of the reader itself, if that makes sense. Tom