From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2FA8Nee62GlDJBAAWB0awg (envelope-from ) for ; Fri, 10 Apr 2026 04:55:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bAR+FDcY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C0A051E0BC; Fri, 10 Apr 2026 04:55:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B3EAF1E08C for ; Fri, 10 Apr 2026 04:55:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1EE394BA2E2A for ; Fri, 10 Apr 2026 08:55:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1EE394BA2E2A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bAR+FDcY Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 5B0824BA2E0D for ; Fri, 10 Apr 2026 08:54:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B0824BA2E0D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5B0824BA2E0D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775811276; cv=none; b=TAFV5fRZHqhOLo702JOgAO/1v8ml73FO/aBhnAy/TG5Yb4GbQBFAx1HuF2nBq40zPSlq2DzYhCAL3dvUGE++LD+eavqEWGSjE+W3++pqjoTX0QbOdAjeDotGjcNkJS4+hsBwEAKPNhsu/V4DAKKdW6scj3e93K0AC/c6CO9TXjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775811276; c=relaxed/simple; bh=Mci8Par5O4tensvhAE9gbFZZBOTUkfY3F77zqS9xjZI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BwvBLfYowaeo+Ub71SiygvE2dNBkeVeVpv9RdKZhaXd8B49N8MHGErpnxXYrp/sV5thNpCuzAmhEUxFz+RoxN1k08onM8VtWPulgcfsFsv3ZtTl8glLFyuejKyoxaJlFlLjIrkHgPafW3CAkxdSGKJJTihYxQ1C+gluPo9o4sf4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5B0824BA2E0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775811276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N5b0RO3KTuTFP/RgxKct59HcTPaiF2Ku1lD9znAZzi4=; b=bAR+FDcYAgGXqnY97J58Rki9pasDN9zXbdoxljhFA9XIdOi8g9iHgqYT5MVnR7UnmwcvpC dd6EhQY4t2AHPf27r3mo1IlSL2/13z5ff4W4goRSYfuVftDSWOGPRdPlf2OePjDKEUOGqc 25IJTNeAT3r3iigqC7sxO4Kls23L8B4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-RdeuQDPFOPCXsotc97bIJw-1; Fri, 10 Apr 2026 04:54:34 -0400 X-MC-Unique: RdeuQDPFOPCXsotc97bIJw-1 X-Mimecast-MFC-AGG-ID: RdeuQDPFOPCXsotc97bIJw_1775811272 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43cff5ef652so1074444f8f.2 for ; Fri, 10 Apr 2026 01:54:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775811272; x=1776416072; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N5b0RO3KTuTFP/RgxKct59HcTPaiF2Ku1lD9znAZzi4=; b=qg/l6I18m1P8YhQGaT+scHqLRG7WrZP0e0TsP2QdXTL7wV1xSNFZSwzL5ousSbM3WM qBFwX2jL7OaUxo336qJ2dhHssJ3cgdED/rA+crvSoSxOaFW/AqjReqKP39iYp7mjY1B3 RyLo+3qjekzzchB81/sGQnOtF0NYEte3cHFgv+ANjlLV/IM5B92XP52Rqw1m8dRk8RzF EzzQVaJ7zCNglSSWzhqUAKvWggqvjA97Gvf6JR/hQr/7yAhz5o2hxplUIjJb9vn70mXD 8Z+cfrid+vC0JhKyd1ei7RtmirbKUAs6VKcbWJO8xf33KBsJLX4JSAJvvS5nA/9qASru 7vtQ== X-Forwarded-Encrypted: i=1; AJvYcCXa/37rhRCaSfr7RV8wswHrzdn1Ofx7j109X4xCCuPf/0z8tAhEPWt3QLYDmKET9vkQTsu86c00BFxErQ==@sourceware.org X-Gm-Message-State: AOJu0YxZsT3TivHPLzL2Fndy4f8u7q01r1LImzEsgu/RgMp1YBn233Mv 3nDSSMkRlXIKDgbgIgAmOJJ+5hP89I5Yu6BknOVaGVRiSe4u2FBggCrFnS5dfT+hbLuRErJPBCV 2xJvq4H/TXYEllsQeJEl29+qXP3yQkAUbDyFMGvYSL01jW3wFItnJQDUklzfpuRs= X-Gm-Gg: AeBDieuL5uA6kLp6XRMEZL8BkwWo+skXZzCLC7V2CEp3prG5I27d/pwC6xyrko8dCNT 71gmCaQg8NhkOHkmF4tnPKird6apIjGe7aVZ3ss/XBfChWodVCEfKnuI6ewhnb6xWI/5l/8t7lM w/9qYDtWTwqdnyJmaOVKn0ZMR/+d3IwIWTyndS7MMpmjCsLy00yfPI94tikS4KnYZ5uKshzaiWH IdJ/vxjZLzZSLQt392ms/IFKUmjk4hZCLH7cC4/SgSAVaMd9oga7K5gfPJXyF7q6sFU5n4rocVL zl/PpAUVycprWD0x/eRSPgaoQHZuD0+xoc+oFcHOWPBa+Vv2BzeUWXqJI3aZ8jHB0r7oP1O6hDO FPg0ecrR6RyN5ayUa X-Received: by 2002:a05:6000:18a8:b0:43d:a58:b076 with SMTP id ffacd0b85a97d-43d642cbb36mr3523471f8f.44.1775811272196; Fri, 10 Apr 2026 01:54:32 -0700 (PDT) X-Received: by 2002:a05:6000:18a8:b0:43d:a58:b076 with SMTP id ffacd0b85a97d-43d642cbb36mr3523424f8f.44.1775811271699; Fri, 10 Apr 2026 01:54:31 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e50015sm6307899f8f.27.2026.04.10.01.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 01:54:31 -0700 (PDT) From: Andrew Burgess To: Luca Bacci , "gdb-patches@sourceware.org" Subject: Re: PR 34052 kill: Terminate inferior with non-zero exit code on Windows In-Reply-To: References: Date: Fri, 10 Apr 2026 09:54:30 +0100 Message-ID: <87ik9z42m1.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Re7Wm-qGq6c6vAd6QN6Qy1ZjeHptHwlOIXoeq3zONfI_1775811272 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Luca Bacci writes: > See https://sourceware.org/bugzilla/show_bug.cgi?id=34052 > > Best Regards, > Luca > From 81457be16cd49c5c7daa5781b287656a8188d483 Mon Sep 17 00:00:00 2001 > From: Luca Bacci > Date: Tue, 7 Apr 2026 12:15:52 +0200 > Subject: [PATCH] PR 34052 kill: Terminate inferior with non-zero exit code on > Windows > > Don't terminate the inferior with exit code 0 (a 'successful' exit > status). Rather, use the standard exit code 137 as for SIGKILL on > Linux. > > Signed-off-by: Luca Bacci Please remove the "Signed-off-by" tag, these have no meaning in GDB, but might do in the future if we ever adopt DCO, so adding them right now is confusing. Also, please add a tag: Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34052 to link to the bug. I don't do much (any) Windows stuff, but the code change makes sense to me. I'll hold off adding an approved-tag in case someone with more Windows knowledge wants to chip in, but I think this is fine. Reviewed-By: Andrew Burgess Thanks, Andrew > --- > gdb/windows-nat.c | 2 +- > gdbserver/win32-low.cc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c > index e25ae81f..964d87c2 100644 > --- a/gdb/windows-nat.c > +++ b/gdb/windows-nat.c > @@ -2352,7 +2352,7 @@ windows_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf, > void > windows_nat_target::kill () > { > - CHECK (TerminateProcess (windows_process->handle, 0)); > + CHECK (TerminateProcess (windows_process->handle, 137)); > > for (;;) > { > diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc > index ddc5e547..adb4c08b 100644 > --- a/gdbserver/win32-low.cc > +++ b/gdbserver/win32-low.cc > @@ -663,7 +663,7 @@ win32_clear_process () > int > win32_process_target::kill (process_info *process) > { > - TerminateProcess (windows_process.handle, 0); > + TerminateProcess (windows_process.handle, 137); > for (;;) > { > if (!child_continue (DBG_CONTINUE, -1)) > -- > 2.49.0.windows.1