Re: [PATCH] gdb: Add support for TLS under RTEMS

[Tom Tromey <tromey@adacore.com>]

>>>>> Kinsey Moore <kinsey.moore@oarcorp.com> writes:

> This support uses the presence of the ".rtemsroset" section to detect
> whether an ELF was created using RTEMS. This works for current RTEMS
> development (7) branch, 6 branch, 5 branch, and 4.11 branch. This
> registers the TLS callback for architectures under which RTEMS is known
> to support TLS. The RTEMS self-hosted GDB server is only expected to
> support TLS in RTEMS 6 branch and the current development branch and
> will only respond without error to qGetTLSAddr request in those
> versions. Other GDB servers will respond with TLS information if
> available.

Thanks for the patch.

> +/* Target-dependent code for RTEMS, architecture independent.
> +
> +   Copyright (C) 2026 Kinsey Moore <kinsey.moore@oarcorp.com>

gdb requires copyright assignment to the FSF, so this line will have to
change.

I don't know if your company has a blanket assignment in place...  if
not we'll have to get you set up with an assignment.

You can email 'assign@gnu.org' and explain that you have a patch to gdb,
they will get you started.

> +static enum gdb_osabi
> +rtems_osabi_sniffer (bfd *abfd)
> +{
> +  for (asection *sect : gdb_bfd_sections (abfd)) {
> +    if (strcmp(bfd_section_name (sect), ".rtemsroset") == 0) {
> +      return GDB_OSABI_RTEMS;
> +    }
> +  }

Brace placement is wrong here but the easiest thing to do is just remove
the extra braces.

gdb uses a space before paren for calls but you might as well also use
streq like

    if (streq (bfd_section_name (), "..."))

> +  if (arch_info == NULL) {
> +    return;
> +  }

Remove braces.  Also gdb has been moving to 'nullptr' rather than
'NULL'.

thanks,
Tom