From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IY9VMo9e/mlEeSQAWB0awg (envelope-from ) for ; Fri, 08 May 2026 18:07:11 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=r5Tg5poz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C9E691E067; Fri, 08 May 2026 18:07:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 40A8E1E067 for ; Fri, 08 May 2026 18:07:11 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4C9F34BA2E11 for ; Fri, 8 May 2026 22:07:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C9F34BA2E11 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=r5Tg5poz Received: from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com [IPv6:2607:f8b0:4864:20::a34]) by sourceware.org (Postfix) with ESMTPS id 590284BA2E04 for ; Fri, 8 May 2026 22:06:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 590284BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 590284BA2E04 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778278005; cv=none; b=T2TvD9IK7HOZnnO3xg44WSdE7LAo2MztuejCKtZMQJcb4HP7rzyPcCbyhdHGEAv+NRGz/1xEkRkN+I0zPgpo63/+Ifsd5j9+KBQWRp5fVDnATYID+UVxDB1JyK70NZlHODLXeBnRj5vuxaYwxse7o4N7bsxT1yeaFYmqvDNntL0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778278005; c=relaxed/simple; bh=seCAb/M1TIu1NWgvlr04u+/rEWRyVgJMQ+HhCn9kitQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JNaFjqUmnCdls7bjIl/EI7nwzA4Fiw5UuTshYsXhomoCtdLuV5Vro4RvWhRGd0FCeRj0o42mBy136L9GAmt9OFUCM+4TeZDK5owY/Y4D/BxPrOo932qcPi+FpAK2z/jbqqw8RiZtQvlRsI0GeMX4VSsZSvAozJeihToyWM7IyO0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=r5Tg5poz DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 590284BA2E04 Received: by mail-vk1-xa34.google.com with SMTP id 71dfb90a1353d-56f75445470so1487765e0c.2 for ; Fri, 08 May 2026 15:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778278005; x=1778882805; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Nd38Eofy/gjP9LhXZhQjMHB6osvzlxNzfjDeSTd9wUk=; b=r5Tg5pozQanosYhDu6eepmrSRdW+kYrYc4WOvb5VYldJ+Q/G211lkj8Mb/vjkPaiVa RiBSbFQGMGyWqjpPnATA2RAtKWZ6udQXDCzXVc9tZiuJ2fUHI7Q8AIFOr5zeNdTWbAOI 0GmArkiwz/c+0Y7T6zGWtEjU9pODaNC4a7gPPPCyHqUge2VcDpzhbaMJNaomcSTuF3L9 Il09aNAYeS5M23HJ6VDLRnGt4doChpyHxVicBTvdPi49b2U0RhC6ebB/X9beNQlRGemt 2vExsxeDPXFTs5iggHzxWChF8HlCJesHjOR4q7c9zlI0SxuHIgeSa92iJ4ROyZkafuHa VHMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778278005; x=1778882805; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Nd38Eofy/gjP9LhXZhQjMHB6osvzlxNzfjDeSTd9wUk=; b=rvr4HLeUt0UVIv50amE/e0LYAlD4vfu8a7e1IEw/voNYgYYGULJ1PHE8Qrqb/uJaG6 uqr/wpL+1lU074cGXzp4x+2EdU071WaNpDhWv+xJCrdWYnryt9GqwcdkXU9KzcwVZnqk H1uaNBGX1IXWQpeD04zUuKO4O7nVHNkeMXv20GP5YjsDcXwusK2qOiVsf8lIR0tyhnQX Io4zkRdd5aM/zlcPL5e/LS6Uiey9vy9Ffby4XfdRAEtJqoCjvm5O5ZFsaxbsAc/1QmJu UeHkAx6TdwK2MBZsC+cjtVETay2KklCrgrFyOi1kPU8LfZIdSOc3HEEtJnEV2YJD3bY4 KTOQ== X-Gm-Message-State: AOJu0YxGXu9KaV88slvyxUiAYUXEIsJgcdum0GCJhDGp//oawDbijW5C TS7I0cmaBcIIqF4UMUB65f7OW4M2iBWi3cwNcq3lQ/xAX9GGmlZjkF0B9U3R9AERSblRV0XzGY7 YG4O5 X-Gm-Gg: Acq92OGVuKOjlgNkJhJAWPWNz3+SewpltOkW5NmNgizdSBrmjrMOOEvm7/lQ+cIIW/X Jvg0vS7kQx6/kVQZJEjPCKCMgv8y56AuwmXW8O9lF199uBMpX24SgtzwQUHsa47/TGKK5zkgM5J 17nWqrG4qudjv7UZrnLaN+G5HCtqXmNLakrNNT/yZ7RzBvTihjwsXkOtq2NdVf+KAcULzveZuZq otH/5r8B98r/UiojeaXuLP6x/hTM5KVrTgoKvzlmdrGw7Ne5EqZZc+5kfBP/u50ECbJqPhxwJ/v 7VOvgTBMhtGRJYmlBlt4NsyeSMPU0gJYEWnYcFAWgroGhNLqb1laMINVWr3csr97LM1M513JB5f dTxGnhNwE6tdJh/SdEY3Nd2FVc1ncfeaeuMQBfRj9zWz2VbnQcTf3ZxvG1ECqtJt/8Lb8oMxpz6 z9oNBwKNsD5wNC+dXucMB9/MXohQ== X-Received: by 2002:a05:6122:e14b:b0:575:37ed:f787 with SMTP id 71dfb90a1353d-5755968ada9mr9212997e0c.13.1778278004717; Fri, 08 May 2026 15:06:44 -0700 (PDT) Received: from localhost ([2804:14d:5c5b:48de::33b7]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-574a6ef15e0sm14780321e0c.17.2026.05.08.15.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 15:06:44 -0700 (PDT) From: Thiago Jung Bauermann To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 00/37] GDB: testsuite: Fix top-level returns In-Reply-To: <877bpdoksq.fsf@tromey.com> (Tom Tromey's message of "Fri, 08 May 2026 11:47:33 -0600") References: <20260429230432.60487-1-thiago.bauermann@linaro.org> <877bpdoksq.fsf@tromey.com> User-Agent: mu4e 1.14.1; emacs 30.2 Date: Fri, 08 May 2026 19:06:40 -0300 Message-ID: <87ik8xd09b.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Thiago" == Thiago Jung Bauermann writes: > > Thiago> In the past, when testcases needed to return early they would do a "return > Thiago> -1" or sometimes a "return 0". Nowadays the style is to do do a "return" > Thiago> without any value. > > Thiago> When creating new testcases, we often copy snippets from older files which > Thiago> do return a value so the old style keeps spreading. In an effort to reduce > Thiago> the bad examples, this patch series fixes the return statements that were > Thiago> easy to find and verify for correctness. I didn't try to remove all of the > Thiago> "wrong" instances. > > I didn't really read these patches in depth. However I agree with the > general approach and I think it is a good change for the reasons you > stated. > > I did randomly sample the patches to see if they made sense. Thank you! I appreciate the support for this change and you sampling these boring changes and double-checking. > Anyway I think these should go in. I can't really imagine doing a more > in-depth review. > > Approved-By: Tom Tromey Thank you! Just pushed the series, ending with commit bf2e321d3659. There was just a conflict in patch 15 but it was simply that one of the testcases it fixes was already fixed by another commit, as I mentioned in a reply to that patch. -- Thiago