From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OQywFQ5jCGqevT8AWB0awg (envelope-from ) for ; Sat, 16 May 2026 08:29:02 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=badSCTCh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 530D91E0B1; Sat, 16 May 2026 08:29:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DCFCB1E093 for ; Sat, 16 May 2026 08:29:01 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7076D4BAE7C1 for ; Sat, 16 May 2026 12:29:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7076D4BAE7C1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=badSCTCh Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E803C4BAD159 for ; Sat, 16 May 2026 12:28:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E803C4BAD159 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E803C4BAD159 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778934510; cv=none; b=e0x0WA9mOHiFqBB5KXl4xaBmqXoR9+mo8/KXieAKzMY0vrKWjt9Zuxla1pOW/XecrR2aWszWAY1/a3oDbyze4iJlZhzU9cj+wspYjZRaw8FBNmETzZ+nMQTkXMhGnv+hbBvjYckeSOu0Q9nsgy0LxjvESgXIN5ro2zXtKB60//0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778934510; c=relaxed/simple; bh=uMJaLPuHGhJEOTJjaOMcptiXWjjk5Te8Y8Jk4s4S9ws=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VQM3zsPs6ASOBhUdDmbZ/1zXkPg4DCcuRlf33AhzvT3CThs92MK2JFb5kw61z+BNU4dcQpm3/0ZLF/BrR7cXM6aU3JCrw5Hr2I0FzMAPKfL3iWptmrQWhe9IZtViAYSc7YGpvUbPAHRjSn5k5WIoVSO7RO7C9DVIdkW4sO4fG8g= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=badSCTCh DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E803C4BAD159 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778934509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FcuXSDw+acDawQ+7wanWT9ffFd3DsnwbaS6TAG6/kJA=; b=badSCTChd6Q7wCRZUlWCbzKDSUb+c1E2hU4l2fLNrR3Rw43Xdk/rc3teyYjTNVkdzKnW7a e1/O/ZQvzVmXXsOVWO2dPvH40o6EGjDi0mqnuIn7hUzqVagq7L/OmHcvKvOyLkTvv+zEqO BPWsMfS+VdKEMpfNVS0qqYlO1e8EQUQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-403N6cBuP-qNw65W5d3Frw-1; Sat, 16 May 2026 08:28:28 -0400 X-MC-Unique: 403N6cBuP-qNw65W5d3Frw-1 X-Mimecast-MFC-AGG-ID: 403N6cBuP-qNw65W5d3Frw_1778934507 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48feb0298d7so5819835e9.1 for ; Sat, 16 May 2026 05:28:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778934507; x=1779539307; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FcuXSDw+acDawQ+7wanWT9ffFd3DsnwbaS6TAG6/kJA=; b=PmgEF7GkyVkIYoN0uk/oEi9Y+EWGqZI9uE9ibD0hiOxAlMg9qwvp3OLRVb5jIjIwp0 hiYTlosc33G4iUV2MG0Y30o7GOMdlC7NBt4/9ve3Ic9wvJ7GAIY1C/9XNmW6An1t7rPx iLEIfPVvjno6iSuUNXFydltGOA9AJ2zJGwSfL6MjJrcRydGvxWe4Y9t943RhW+ggkd4K /WtYGCRJ2qwCeIGcwGV4qV8gx+S89pDHPFjfFNoAMdd2U61wrqtzJwI1cHqLS+jQ8k8j jINKms7XjZ0PJUydXTmpd/87YZlgm+X6NycX6fi23XiETBCIpHX3AAt5FkjuhQpj5uwp 0aKg== X-Gm-Message-State: AOJu0Yy6MO/R/0B1StSiSmqlWPTIByBpS8c2uxV8Jl4MGgeiC8SGxaVL 1PFhkUivZp6y6PxUXGqaPHtmFnIYv5cGcsYy4WAaB3UO8mca4h7GmEYc98GujNpyCyH3dnQNtjD Jwohp47jGlXZiZWwyCth0NF8L6EJnFAqbp48qpyHRulbPl1HjUn/e4RX+Y1Gq+28= X-Gm-Gg: Acq92OEkO2Df9ocD8xU/RjSP4gHIo12YPcWDxDlyUcRkSHZu41jRrKKBxExPDTv0skk 10yZjCoJa333awaLPfld4tgZLls+LGDkK3KZa2SPEFaMBup59PLgMcEVpl+0HNJc9a4D0Boumqk nb96WVKF+iHKJonBqm5J6nJXx33gUU01Vx0POhGGAU0IAzsc8Upb92fB3G1l2V2kFAENELLUItZ VQAynBsWyDEqXSGmq2PgOOo5RxInijq+yPfsiaUB12ngPLgQTKmflVcQnc2HVWduQfVv0vnD7N5 vryhwuYLerqNsy0+ry1bMnXr0jZQVjGmQrk3TSAfA2kcZ02V5yei48BGp5M5HCu3NuyFAUmF5Ho HYfDNnVqKqBopZjjE5A== X-Received: by 2002:a05:600c:c10b:b0:48f:d612:3c59 with SMTP id 5b1f17b1804b1-48fe60eb0f6mr76955375e9.9.1778934506799; Sat, 16 May 2026 05:28:26 -0700 (PDT) X-Received: by 2002:a05:600c:c10b:b0:48f:d612:3c59 with SMTP id 5b1f17b1804b1-48fe60eb0f6mr76955095e9.9.1778934506390; Sat, 16 May 2026 05:28:26 -0700 (PDT) Received: from localhost ([109.144.20.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe5376812sm142982155e9.11.2026.05.16.05.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 05:28:26 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb/python: fix use of frame_info_ptr within pending_frame_object In-Reply-To: <87pl2wh9l1.fsf@tromey.com> References: <87pl2wh9l1.fsf@tromey.com> Date: Sat, 16 May 2026 13:28:25 +0100 Message-ID: <87ik8nczdi.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NBTtlOjqvYW5w9Qoi2POY3cYcqqPKUBmb5Ty29t6wI0_1778934507 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> The problem with frame_info_ptr is that its constructor registers the > Andrew> new frame_info_ptr with the global frame_list. It is by this > Andrew> registration that invalidation of frame_info_ptr objects is performed. > > Thanks for finding & fixing this. > > Andrew> + frame_info_ptr frame (*pending_frame->frame_info); > Andrew> return PyUnicode_FromFormat ("<%s frame #%d, saved_regs=(%s)>", > Andrew> gdbpy_py_obj_tp_name (self), > Andrew> frame_relative_level (frame), > > This could be 'const frame_info_ptr &frame (...)' and avoid some updates > to globals, since no copy will be done. > > I didn't look closely but perhaps other spots could do the same. In fact they all can change! I made this update (and retested) before pushing this patch. Thanks, Andrew > > It may not matter so if you want to ignore this that's fine by me. > > Approved-By: Tom Tromey > > Tom