From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: simon.marchi@polymtl.ca, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb, gdbserver, gdbsupport: use [[maybe_unused]] instead of ATTRIBUTE_UNUSED
Date: Fri, 26 Jun 2026 09:20:15 -0600 [thread overview]
Message-ID: <87ik75wcpc.fsf@tromey.com> (raw)
In-Reply-To: <56913a13-2ca4-4c0b-be00-5f1c479122a7@suse.de> (Tom de Vries's message of "Fri, 19 Jun 2026 14:49:10 +0200")
Tom> these both look fine to me.
Tom> Reviewed-By: Tom de Vries <tdevries@suse.de>
FWIW me too.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2026-06-26 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 17:50 simon.marchi
2026-06-18 17:51 ` [PATCH 2/2] gdb, gdbsupport: use [[nodiscard]] instead of ATTRIBUTE_UNUSED_RESULT simon.marchi
2026-06-19 12:49 ` [PATCH 1/2] gdb, gdbserver, gdbsupport: use [[maybe_unused]] instead of ATTRIBUTE_UNUSED Tom de Vries
2026-06-26 15:20 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik75wcpc.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox