From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qF42IzquRmrYsiIAWB0awg (envelope-from ) for ; Thu, 02 Jul 2026 14:30:18 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=C1pUVX+N; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 801741E024; Thu, 02 Jul 2026 14:30:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D1791E024 for ; Thu, 02 Jul 2026 14:30:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 892AF4BA23EB for ; Thu, 2 Jul 2026 18:30:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 892AF4BA23EB Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=C1pUVX+N Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by sourceware.org (Postfix) with ESMTPS id 02B224BA2E0A for ; Thu, 2 Jul 2026 18:29:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 02B224BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 02B224BA2E0A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783016992; cv=none; b=fe9M3lYtNBOSZHVuYTmfRsRVkFXfUT8rOexhuvNBOumrMOSrHjAmGBmiSJl0Q/xBj8ZcSFpk31CV5zfAQO3ku5bK8wxR9o/vCiIQ8+5yXIshaQ485d8AsduDcsvY6+qVq/6q/6oSkbJiKwdUYrSHoDSatFwXS5lHbY4jmun4x3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783016992; c=relaxed/simple; bh=6rIO3Q8xipvsqmjqwUdkp3bgHeBXmOi2t7/Ma3+AxGA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DvhOjmMP0CtLYU+jisJLmkn4E4DH+hMQVIXJInapjwjU5sldZ714nS3vDgLiqhr6nuCFs0HQF6MtghaxyfwX5hV5U5vAiGvcTPO18QldvXNBQcDlvXk/13mHJDMrHM/nWbtZamdg+DgZ2Cx49pRG8i75+lDRNVYtm4S54bATRKA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=C1pUVX+N DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 02B224BA2E0A Received: by mail-oo1-xc2c.google.com with SMTP id 006d021491bc7-69eb8b6bea8so1037449eaf.3 for ; Thu, 02 Jul 2026 11:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1783016991; x=1783621791; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PgxLIQHmzTHz0hO/mwSCgy18g/zP5YhRj0VQb/mYG8A=; b=C1pUVX+NrLDEG/cWuUj8zltNT30NH4VDvIcvXBp0zYb0KkHz7xj9CSlh5nPgAKNtIh VAGZJVhCI+VW5Wef5z1aIiEQacErkmjb7QW4yXYq7x2/ERktF3AX2vE6nX3DdbRx2yRu 67SHY35du7/+F2L53k7MoS6amXNub7qRv50Q63lBuTziT0tfTgpPkCCrDDTlIvlY5a+r ZJi+1Cl4xXgATg6Pp/fXrYCE4yfCt5hvc2JqOP+WJAUjwVxj3li+vqmWMxP93l8cDwvf p0A3kfmakifxfG8yXE+aCXbUAsLRH2AFImqnSLdszEK8wEKfCMV7yO48KEp5icDsIvLI cPlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783016991; x=1783621791; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PgxLIQHmzTHz0hO/mwSCgy18g/zP5YhRj0VQb/mYG8A=; b=pmBTOWUDhN/7WYGLVoPqsu4BIK9VrZp4l3Bodp4jau7q4sS1dYFI/o2Kavu9SY8T+m gamGJxdoZlss7PzF/bYs1V0YMUiiONkk6f1wu5A2QSVehvKGtidTFGDM71eobwR4bYYg FV8WsOOQxjfgytvmt9pA7OmIiv29t1F5u4Llv3NCc8PcS8fd8Ne8cQPdBsiMQrkXXRVB pyfhZNbfPGiCjU3QVBoKPv7Gx9G01L9uuJFCAsi3bIZPDbBoNEFxttm3MmnMs5pJFvQz tkwp95DIq24e9KESosLTc8Ox3BdpCJvV1PYvVU0MhXIvfaVCRGYSxR1wXeKkFm1leWvx PNxA== X-Forwarded-Encrypted: i=1; AFNElJ88kRkoHlL85ww98weREktvXncGfjejDTfqm2rAobsUKrTpuj7mx/rbRjwrDlXoNR4cW438BuUGmoweNw==@sourceware.org X-Gm-Message-State: AOJu0YzwBmsEXlL1JksYRMfV0cDUUByxOSgdeGnxWe+LV2ATc22crB4E Pf/KHNXSmfWwqVUDeR8CljtX+uXMPR5/X7jQt+H2SFmvHpSNNdW/KyeiQWu6PQm1HQ== X-Gm-Gg: AfdE7ckOZQwt1dXL2hj+7XB/G3GDMldi1/k/sRi2NB3gAmcPcSQ1Z11NHOUTTwVy/Ik cVbA10JEvKsZhXBHYdYj/MyDHT7CCrcuGK+q2C8qq4Ppf+3MGXGtEf1PbfgbZKsy0QQ/yIzJteY zO7pBJotxTYzP2OLGYQyOAyTDbL2yH7wwbgzfpmJGfgOL3SacR7TqlRy5HJ+QHrNbMXTQ0EGqvy 2OSwYtnoLZv5EB0SJWLl4yNY5+XvDp6LmK4kS4sE2jqC3U68MQeIrrx/Ty5bqGqjdjOmrTsaAgB ZusPn0/in9wSlgqMezcEpML7lkTP2iXFH94AAQ3tTbq9fn/vl2IVqa0i7Gk1wJmSaW4r76cZ4vq Q2/Rl4sF9MoPXW1zboOli7TDItqmK82wk3dkGdmoEt6zZ+j7s9El+z/UDqMaToZrpxaMYIS1y+s T8pb3ulrNMJ7/8L8WjJ+iwO64Fk6id4B0ucEg8JsmjmDg= X-Received: by 2002:a05:6820:1610:b0:6a0:d9a3:fba4 with SMTP id 006d021491bc7-6a309964088mr4217498eaf.14.1783016991018; Thu, 02 Jul 2026 11:29:51 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-44cbe841750sm3840186fac.3.2026.07.02.11.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 11:29:50 -0700 (PDT) From: Tom Tromey To: Mark Wielaard Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Do not write negative PID or TID in remote protocol In-Reply-To: <20260702101855.GI4673@gnu.wildebeest.org> (Mark Wielaard's message of "Thu, 2 Jul 2026 12:18:55 +0200") References: <20260430175904.1342455-1-tromey@adacore.com> <20260702101855.GI4673@gnu.wildebeest.org> X-Attribution: Tom Date: Thu, 02 Jul 2026 12:29:49 -0600 Message-ID: <87ik6xfdnm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Mark> It looks like there is still something wrong on 32bit arches. Mark> At least after this patch the i386 debian buildbot fails: Mark> https://builder.sourceware.org/buildbot/#/builders/105/builds/12989 I'm sorry about that. This patch turned out to be kind of bad. I built a -m32 gdb to reproduce this and I'll send the fix shortly. >> + hex = hex_or_minus_one (p, &pp, for_remote); >> + if (pp == p) >> + error (_("invalid remote ptid: %s"), buf); >> + >> + lwp = (ptid_t::lwp_type) hex; >> + if (hex != ((unsigned_lwp_type) lwp)) >> + error (_("invalid remote ptid: %s"), buf); Mark> Are the types/castes here correct? hex is an ULONGEST that is being Mark> cast to an ptid_t::lwp_type and then an unsigned_lwp_type. Then this Mark> sanity check seems to fail (on i386 at least). I think this is because Mark> ULONGEST on i386 is unsigned long long, while unsigned_lwp_type is Mark> unsigned long. Yes, I agree; and I think the fix is to special-case the "-1" value here. Tom