From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MZGEBTJqW2qR7RAAWB0awg (envelope-from ) for ; Sat, 18 Jul 2026 07:57:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gHmdjRV1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 09F241E099; Sat, 18 Jul 2026 07:57:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 808BF1E099 for ; Sat, 18 Jul 2026 07:57:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1DAC64BA2E1C for ; Sat, 18 Jul 2026 11:57:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DAC64BA2E1C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gHmdjRV1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 6BEBE4BA2E0B for ; Sat, 18 Jul 2026 11:57:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6BEBE4BA2E0B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6BEBE4BA2E0B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784375832; cv=none; b=U8PXHP9AfYW2TK4Acp4nh08MYS3rhArOKoGE9XHvwst2Kx+MefVh3PrT2o/qh5D7X7jJJBRa+LejWtzpSfEyux+bETdgogmpEL+qrxipdPnxeKFj7zeoIerDScWf1OlLdpDPw9/ngmLdI69vOM30Q4J6dYTJIerJ2KJVEPo2e1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784375832; c=relaxed/simple; bh=+SUz6//szNEL/457g0KE2xugWTUEiqtacWxsH7Xc0Yw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FhTeBnJbqtRKFSQDrWNO5e0slzo5ImtqceOGTYu/LeyNwzbg4abevsdcAnlRe/GmMxW8HdSReFkkg7m9mhWeZjXsDqFB8l6GGU2N2BH6SsJgjOA8IH+gGWd39TzJBRC1/QYTFHrWZYLJfI7bllJyhIC90bnlNru7a1SjqBOaCzY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gHmdjRV1 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6BEBE4BA2E0B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784375832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XSa1+2w9tIkm+QJ/W7pp/DT2QUGARrXKovFKut2VYCM=; b=gHmdjRV1hdj+vwH8cmf/eTiJN+eRH/Tn3n7qc86jtYJgMkzHudifQONDvtj90pnuqEc5OK EMNZ44kM5S8sLGsrspg/n6T4TPlPXAShfP07wRqaAwhaQjyaSSd7+ywexFNKcQuBM316i0 2pCoBpaaGf31zOldw4mCMN8/iBCSecs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-MsFOG3HCP6-yy-tmHFPm_A-1; Sat, 18 Jul 2026 07:57:10 -0400 X-MC-Unique: MsFOG3HCP6-yy-tmHFPm_A-1 X-Mimecast-MFC-AGG-ID: MsFOG3HCP6-yy-tmHFPm_A_1784375830 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-493b0a5e636so79195335e9.3 for ; Sat, 18 Jul 2026 04:57:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784375829; x=1784980629; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=XSa1+2w9tIkm+QJ/W7pp/DT2QUGARrXKovFKut2VYCM=; b=gWMGkkBGjMY5UNCL1gga1/dzuCPttlQRDSalCqA1ybGXZKlOyzO2nA69PLjKoK1sFG 4EY+O7rTzsTVhwZj4kWT9HynMjC+ld+sclZNxosdxg2HIzMN/fin7+Co13htLMmYkUIX IUZbQKPf0jMRtPNjZX2rph27b7qL84oeBUPnXnm32FZnSkH014MF97hDihgaFYE32Fzx 3PbENu4YPMZ59moyS8FVrp/6F9yrZnTswQ11EL30EtoOOHpktcuMzVprj/0nBH9RqIh7 2MueCBMOjaXlRf8JTitqb2k4/wnmSrhusfifiZmGE+803vhOqZOC0St/CrmSQ/nsijnZ t8rQ== X-Gm-Message-State: AOJu0Yy27HHwenUy8UOVEn3T/tnXFX3KSt/nQbK5CGgYMdJG2I+b/XqD 5PpdETAItZTm64UqN5AkvByyvy8W/6JQdqEwpn9tib2kCiIdiH9NXDv2XVY6G91hkNjlh/yOfwv 6HCRCk7kb8tVEvcHdCR/sOSYbXLBGFBshw75twofwknOGQIWTCcwiXv9ckO9/bMGMx1JBGkM= X-Gm-Gg: AfdE7cmXKJm6CEa2Yor8YYUOH2zlUBWIf+7wbzfQwmPFKBHktDZwLzrU7oIMaQ6ugoV QemXG0IhLp5UsE8Spi45vG2OuyMtJ1LTCHkzWibrlM6DcQHk3xFtiFLeaM/c3IDlGZX7l8tTy/1 OvdZK30uz/89bgs72rwrDqm4iuZA6RgXjTb2C4+3Hz+6hn68WOyFMLAPOLRzqkeKxDZR1Tk/aE2 kxMhPeUnJGPLekyDN2RUgRC8Cc6+T/MqwRrJJo75qEecYxfX71swr8iRNN0aAC0DBwNEJqftW5F 8zXNw3ZrEBM/MYjh8uql311d0UIOvwKFhh7ELIHMqrWER8Gq8lDPzRNFhnzgyAisgsw4X3OMtrO 8SfuwqKgoJ1nZG4q97FHNbIzs X-Received: by 2002:a05:600c:4ecb:b0:495:4c73:3d59 with SMTP id 5b1f17b1804b1-4954c733e07mr58249705e9.23.1784375829606; Sat, 18 Jul 2026 04:57:09 -0700 (PDT) X-Received: by 2002:a05:600c:4ecb:b0:495:4c73:3d59 with SMTP id 5b1f17b1804b1-4954c733e07mr58249535e9.23.1784375829136; Sat, 18 Jul 2026 04:57:09 -0700 (PDT) Received: from localhost (92.40.184.195.threembb.co.uk. [92.40.184.195]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49549c96f19sm133590665e9.9.2026.07.18.04.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 04:57:08 -0700 (PDT) From: Andrew Burgess To: "Rohr, Stephan" Cc: "gdb-patches@sourceware.org" , Tom Tromey Subject: RE: [PATCH 1/1] gdb: set the cache information in 'get_prev_frame_maybe_check_cycle' In-Reply-To: References: <20260625145850.3104079-1-stephan.rohr@intel.com> <20260625145850.3104079-2-stephan.rohr@intel.com> <87se69wdbt.fsf@tromey.com> <87zf04tawh.fsf@redhat.com> <87ldbmu6py.fsf@redhat.com> <87h5m9fuqi.fsf@redhat.com> <87a4rteh7z.fsf@redhat.com> Date: Sat, 18 Jul 2026 12:57:07 +0100 Message-ID: <87ik6ccxyk.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: o-aVHp86n59_hUz1gUhWcC88xJwPXcdEt3srch7sI2I_1784375830 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org "Rohr, Stephan" writes: > Hi Andrew, > > thanks for getting back with that. This was also my first approach > to fix the issue. The only limitation I see is that we have a duplicate > entry into the frame_list when we setup the return value. When the > dtor of prev_frame is called, it is removed again. I see this the only > side effect of the patch. Sorry about that, I guess I lost track of the original proposal somewhere along the way. I've gone ahead and pushed this patch for now. I ran into this issue again with another a second series that I'm working on, so I'd like to see this fix landed, and it looks like we're both OK with this approach. I agree there are some minor costs, but I don't see them as significant, and anything else will also have some cost associated anyway, so I don't think this is obviously that much worse than anything else. > > I'm personally fine with the proposed change as this is a minimal fix > for the bug. I agree that a perfect fix would defer the frame_info_ptr > creation until the frame-id is computed, but I think this is out of > scope for this patch. Agreed. I have this down as something to look at in the future. I have another series in progress that touches frame related stuff, so I need to see how that will go first, but after that I might revisit this. Thanks, Andrew