From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /GGQFGXOhWr+vDAAWB0awg (envelope-from ) for ; Wed, 19 Aug 2026 11:40:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Iw1SvMfQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 34B341E0A3; Wed, 19 Aug 2026 11:40:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3BE911E033 for ; Wed, 19 Aug 2026 11:40:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DE4574BAE7CE for ; Wed, 19 Aug 2026 15:40:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DE4574BAE7CE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Iw1SvMfQ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 54F014BA23E4 for ; Wed, 19 Aug 2026 15:39:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 54F014BA23E4 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 54F014BA23E4 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787153994; cv=none; b=pk2KrD7zxrlzm7fZoue9iSD0mXYRpcsg4NBagyQCJqmBVrb8sor/NEzFisavl8/L1RQmH7SRs6AUTnQA/gaFZrWEuYAj6/+lEFY2OwBjQqNmAS/Y7o6ph09XLHuL+dKyHMVSXvyVwM3jbT3lAqLEAdnUS9HLl1AAMc4k8xiWvlQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787153994; c=relaxed/simple; bh=SD2yXAno/QTHaDj0EBQwBWmqVwQ8FuT3eHLkZJVgpwk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=S+nwtbRNvN7R1Up24WC4k1K7QYrFme9K7y1MSRF20fEc6hRQEneVvwf+1ELQgjsEhmAbQ2l4hlGUNPDNQijGC2zMg5IwZoJnGSUsQ3lA5pCVt9D05zJ7O1/wpvxRU3djuRgYhd5cimMMHliDSG7ENXrmR7z3BjtqZUe5jayVW2M= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Iw1SvMfQ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 54F014BA23E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787153994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o4XCTSUYy0sBbGH6Qun44w37eZlInZdBbD8uShcdSl8=; b=Iw1SvMfQ35bftfnln2ib9hzi01fryxqHlzUvLQ1Jyq793dftsgGwWK7Y1ESQD9D937RAyn vlHKb5Cv0aZ5qxR+ecaNrvMQEcmlmke3aL1u11ExUje1R7M0+3mwTd79F4fEGJPIAx9jAa qXMHNtLKG6IRwoC+R31b6W5Soa6OSUg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-6rkTU8KLM9CvjSlbM3mLMg-1; Wed, 19 Aug 2026 11:39:52 -0400 X-MC-Unique: 6rkTU8KLM9CvjSlbM3mLMg-1 X-Mimecast-MFC-AGG-ID: 6rkTU8KLM9CvjSlbM3mLMg_1787153991 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4994aebe932so13431685e9.3 for ; Wed, 19 Aug 2026 08:39:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787153991; x=1787758791; h=content-transfer-encoding:content-type:mime-version:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QIoSkeq9vRiikV1iBl67b4awjr5NkyeotYSGEO7V8E4=; b=nCqvz9/I+9xe75hVKwi9s4tUN1gCcl49sJnevJ86DqPnaDfb3YQRvmUYOKhj3/cId+ 3QPt1EDB2Tkom/ytqKvuI45109nr0GFT2TCyx/8VSGa5Lp5cAGfgle8guNIXiICwlhNf PL4FsWGydQ+ZNZCURe0UNSHLlEkb+k3l5c+gAEsqimoh8CPBsnT3siKGiTc+Ld/K9GmF /lt5L4uf8xYiIA9kBSksoMTE/J2Uno+bIA18w8AEF+itIwGd6nBkmZniNZU7rEDpUyWV zP1OJY4jH8RCoT3df9TMpc784VseXZdhjJZaHNRcsGewT9CFshZzB5cxnRCuVYtHpIV4 gnDQ== X-Gm-Message-State: AOJu0Ywo2900/fClEWG4FANI96Lz2YQST7YAbpmvdeuEEH46OwzcZKMN 8OpOS5zL5XYRxUKU03b1lpepMvxBMHGOQgH8C3oKam73ZQvpc0l9NcufD6DQzBYsn8I3kFP/cd0 p0MG5SGRJZ+nwTxbvuFZKI099Qkp/2RgZNd/nzk2tTu7N7IBQiVBI0hVzHBm88b4= X-Gm-Gg: AR+sD11XsFRLrYfHdgnXf9pwYjEHNPQBnUHmAoHcDIuxry/7akqgJkI+W9gLO8F0sqd 9fZ9z9/lG0rV7O147OeewTZEp9CjG0PygAsN+1FIL5kdXGCZJBLMJJJv65vQvgKj0Ryg9nn/O/0 rug5A3LZrmOMLP+pt2bzTWzueWEEPLnpw5enGz7zKQNR/IaykGCmomnsv1ResNhscwIcdXX7kmi SMx74zv8Es1L+WP5BR/+R/6fk8Bvl0i5xbPhp7MsB3MpX+i5mFwTOa/b6NVboL6W9MtNIIqixTH cjs9ZyL5x69CCe6JbsJ+CuMnsnHGVCA7POfhkmpRNXtHeA88LZqMuFxtNnQXlR7XCo+scrS0XFO zjVjioiyGCkekiWc9rnI= X-Received: by 2002:a05:600c:3b03:b0:496:bbce:fc with SMTP id 5b1f17b1804b1-499aa1f361emr87145155e9.12.1787153991415; Wed, 19 Aug 2026 08:39:51 -0700 (PDT) X-Received: by 2002:a05:600c:3b03:b0:496:bbce:fc with SMTP id 5b1f17b1804b1-499aa1f361emr87143715e9.12.1787153990798; Wed, 19 Aug 2026 08:39:50 -0700 (PDT) Received: from localhost (67.72.115.87.dyn.plus.net. [87.115.72.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14c45d1sm5468334f8f.30.2026.08.19.08.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 08:39:50 -0700 (PDT) From: Andrew Burgess To: Hannes Domani , Rainer Orth , Eli Zaretskii Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix procfs.c compilation on Solaris In-Reply-To: <2046993386.3119504.1786708175630@mail.yahoo.com> References: <86lda97x7i.fsf@gnu.org> <2046993386.3119504.1786708175630@mail.yahoo.com> Date: Wed, 19 Aug 2026 16:39:49 +0100 Message-ID: <87ik5615mi.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BkNoiqlbnzBvcTrV4rrIIVLoWkBsuKw3MbIF0_yatYQ_1787153991 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hannes Domani writes: > Am Freitag, 14. August 2026 um 13:34:30 MESZ hat Eli Zaretskii Folgendes geschrieben: > >> > From: Rainer Orth >> > Cc: Andrew Burgess >> > Date: Fri, 14 Aug 2026 11:34:14 +0200 >> > >> > procfs.c doesn't compile on trunk and the gdb-18 branch: >> > >> > procfs.c: In function =E2=80=98int procfs_notice_thread(procinfo*, pro= cinfo*, void*)=E2=80=99: >> > procfs.c:2857:33: error: invalid use of non-static member function =E2= =80=98thread_state thread_info::state() const=E2=80=99 >> >=C2=A0 2857 |=C2=A0 if (thr =3D=3D NULL || thr->state =3D=3D THREAD_EXI= TED) >> >=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 ~~~~~~~~~~~^~~~~~~~~~~~~~~~ >> > >> > Fixed by calling the member function. >> > >> > procfs.c: In function =E2=80=98bool find_memory_regions_callback(prmap= *, find_memory_region_ftype)=E2=80=99: >> > procfs.c:3152:15: error: no match for call to =E2=80=98(find_memory_re= gion_ftype {aka gdb::function_view}) (CORE_ADDR, std::size_t&, bool, b= ool, bool, bool, bool)=E2=80=99 >> >=C2=A0 3152 |=C2=A0 return func ((CORE_ADDR) map->pr_vaddr, >> >=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ~~~~~^~~~~~~~~= ~~~~~~~~~~~~~~~~~~ >> >=C2=A0 3153 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ma= p->pr_size, >> >=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ~~~~~~~~~~~~~ >> >=C2=A0 3154 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (m= ap->pr_mflags & MA_READ) !=3D 0, >> >=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >=C2=A0 3155 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (m= ap->pr_mflags & MA_WRITE) !=3D 0, >> >=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >=C2=A0 3156 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (m= ap->pr_mflags & MA_EXEC) !=3D 0, >> >=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >=C2=A0 3157 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 tr= ue, /* MODIFIED is unknown, pass it as true.=C2=A0 */ >> >=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >=C2=A0 3158 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 fa= lse); >> >=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ~~~~~~ >> > >> > Fixed by passing the new HOLE arg. >> > >> > procfs.c: In function =E2=80=98void info_proc_mappings(procinfo*, int)= =E2=80=99: >> > procfs.c:3257:25: error: too many arguments to function =E2=80=98bool = iterate_over_mappings(procinfo*, find_memory_region_ftype, bool (*)(prmap*,= find_memory_region_ftype))=E2=80=99 >> >=C2=A0 3257 |=C2=A0 iterate_over_mappings (pi, NULL, NULL, info_mapping= s_callback); >> >=C2=A0 =C2=A0 =C2=A0 |=C2=A0 ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~~~~~~~~~~~ >> > >> > Fixed by removing the unused arg. >> > >> > Tested on sparcv9-sun-solaris2.11 and amd64-pc-solaris2.11 with result= s >> > similar to the gdb-17 ones. >> > >> > Committed to trunk. >> > >> > >> > This patch should also go to the gdb-18 branch: I'm not sure if I shou= ld >> > just commit it or it needs approval. >>=C2=A0 >> The rule until now was that each bugfix on the release branch needs a >> Bugzilla report. > > AFAIK a bugzilla report is only necessary after the first release on that > branch, but a global maintainer has to approve in any case, see: > https://sourceware.org/gdb/wiki/PushingToReleaseBranch This is how I've always understood the rule too. I'm happy to see this pushed to gdb-18-branch if it has not already been done so. Approved-By: Andrew Burgess thanks, Andrew