Re: [PATCH] Add drg_why_sleeping.py

[Tom Tromey <tom@tromey.com>]

>>>>> "Alexandra" == Alexandra Hájková <ahajkova@redhat.com> writes:

Hi.  Thanks for the patch.

I'm not sure this is really something gdb ought to ship.

Alexandra>  sleep_test.c                                  | 76 +++++++++++++++++++

This file shouldn't be here.

Alexandra> +           (gdb) source ~/binutils-gdb/gdb/python/lib/gdb/command/drgn_why_sleeping.py

Normally commands are auto-installed.

Alexandra> +           (gdb) drgn_why_sleeping

This isn't a very gdb-ish name.  At the very least gdb usually uses "-"
as a separator; I always thought maybe it inherited a Lispy style from
the RMS days.  But maybe a prefix command would be better anyhow.

Alexandra> +            raise gdb.GdbError(
Alexandra> +                (
Alexandra> +                    "Can't find selected thread. "
Alexandra> +                )
Alexandra> +            )

Extra parens?

Alexandra> +                    "Can't read /proc/kcore, %s. Try running GDB as root. " % str(e)

We can't ever recommend running gdb as root.

I don't normally like to make drastic pronouncements like that, but gdb
is nowhere near hardened enough for this kind of thing.  In fact it's
more accurate to say that gdb doesn't even try, it's ridiculously
exposed.

Tom