From: Tom Tromey <tom@tromey.com>
To: Jan Dubiec <jdx@o2.pl>
Cc: gdb-patches@sourceware.org, Andrew Burgess <aburgess@redhat.com>
Subject: Re: [REPOST][PATCH] H8/300: sim: testsuite: Use the correct file descriptor for stdout
Date: Thu, 03 Sep 2026 10:59:25 -0600 [thread overview]
Message-ID: <87ik4m2rv6.fsf@tromey.com> (raw)
In-Reply-To: <20260827083334.1637356-1-jdx@o2.pl> (Jan Dubiec's message of "Thu, 27 Aug 2026 10:31:05 +0200")
>>>>> "Jan" == Jan Dubiec <jdx@o2.pl> writes:
Jan> This is obviously a typo, because the file descriptor for stdout is 1
Jan> on both Linux and Windows. As a result, the test cases returned nothing
Jan> on Windows, i.e. neither "pass" nor "fail".
Jan> It works on Linux, however, because file descriptors 0-2 usually all
Jan> refer to the same underlying device, which is opened for bidirectional
Jan> I/O. File descriptor 1 may be line- or block-buffered by libc, but once
Jan> the data is actually written to the kernel, it ultimately goes to the
Jan> same underlying bidirectional pseudo-terminal device.
LGTM.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2026-09-03 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 8:31 Jan Dubiec
2026-09-03 16:59 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik4m2rv6.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jdx@o2.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox