From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mbT3C9bLnmrnVDQAWB0awg (envelope-from ) for ; Mon, 07 Sep 2026 10:36:06 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aAQf6h2W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 284EF1E033; Mon, 07 Sep 2026 10:36:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 050351E033 for ; Mon, 07 Sep 2026 10:36:04 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A2D74901418 for ; Mon, 7 Sep 2026 14:36:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A2D74901418 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aAQf6h2W Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8B43348F66C4 for ; Mon, 7 Sep 2026 14:35:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B43348F66C4 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B43348F66C4 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788791738; cv=none; b=SWsAquPfKU3dCBkEqhK43soVBrDFGf69hAegrWh0w7WLiP1P97Gg+evhrYwGnhjtu/kAWyTYP4ncII0FOrpsMzVOr+tFuK4nIXoUvzjjD+DsZBRBL2QIzhKXKq5dRxjz6M/V5oqsKgUyG6mHkKvbhq57ai+t0Muj3L/tLm/dj6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788791738; c=relaxed/simple; bh=pn2oM6t3v7TYUjIjDYUjuesWJEdNmpoN9FyEklCFl6I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UNQ11kYAOcmGBjAxRMrYxsd0bZCCcTQWJVE7It+42lP7qpTD/+Z5kh0MNLY9oGr6vdm8NULud7NBgPcJ0neWIkKAT3j1rPAO8TXN14F/54V5ErsXVsZc/5lJ0CkTaxz+WS74/Fbr3nqct3fDNkA6fORlo2xBiTRSlvOQaQz+OjM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aAQf6h2W DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B43348F66C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788791738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qiYvoVWr25P3DQ0sIY6lr5lCblzCdq8HJOr9Hf44pfw=; b=aAQf6h2W89OnRRxk4mewEYHjBhxOirTP1DJNcsx48j1z9w5+6ZzpgO9EBGkhxiYDNan6rT fAacYE67Cn3pp35wsLoynXZZg+IoTeUM+K16JyYdjhInPGTVi/KbrDc59yVUO4FG82YiZp aF9iqEl+Eir92zjxp1yJOJ3jO43LFt4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-338-X5eSuJ3SPUmg72m5uhIQdA-1; Mon, 07 Sep 2026 10:35:36 -0400 X-MC-Unique: X5eSuJ3SPUmg72m5uhIQdA-1 X-Mimecast-MFC-AGG-ID: X5eSuJ3SPUmg72m5uhIQdA_1788791736 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49d156c917cso4846645e9.1 for ; Mon, 07 Sep 2026 07:35:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788791735; x=1789396535; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=qiYvoVWr25P3DQ0sIY6lr5lCblzCdq8HJOr9Hf44pfw=; b=nP9ZpxnzlCKsGOyn1bJW2vWLjMmROtj6U/iuXkeo0+NBaJU++cicQIq3HubBuCI1yc 6jUHmlY0ANWU4mutpERuucDoAQekdirpC0s6tVifRrP7hrIkuwPbZB7859DgqSuJxIq1 wC5fK9zwS8hyRfqFsmy/poIKnrs2nIImrx06lLSFWHsTbn/Ud7XB/ejwa/+Zu2wBJ9iC jxlkArBGYyyb4vPHttQrS4mfNtSYzCpkccUuOBea196aKWKeDgMXn7BFZmjkfo0M8Krj WpblCo1hPlT0KwAwcheIh9iZ2iIh+X1xI5sn9YBJOtDvIbAsHplOFDXmzXuIigko3mdh riaQ== X-Forwarded-Encrypted: i=1; AKwUvBwxM/bSsykVkzjTnNRe3BdHfOtobDn/G3tEW+ikK32SLberuPb7VALb8wE3ECTywabjfXvoEz0dm6fCZA==@sourceware.org X-Gm-Message-State: AFuF++lqlTcCwnqPIz/Uuo/3CKgzZz5xucqU8j8VaesK8lPChYIFnmeN UgcaX96+UwdiD/88KnJgtJ3K+lo7HBdweKBUXROZxXjaeuvwEhCPM8XBHDy3mYm5Q3TQvy3nhAU a0JA+csks6bfZXh2/CHg99oRSAJxkQi27RL8cGI29tE08dUyQbg46QYj8T1nZHyJhRDhneQI= X-Gm-Gg: AYBFou2NmoQbloGdeLCF2e/d1jKIIYUTj7EXoRQtn3eN7E6wVNGDcFaqQP4mkVrNk20 //PoX+oS/lYIhmXZY4LX4Ax9qIMv8XpbhjCAzFkU0FLB4egFJia9tbFowzwqXNEetzyTL24ZxBj UCNQmF9qJNLV3MkDDqKDTLwPUQPp4H+LNAvdPPVgotCDzj7oP//5SekxpE9wpAQzSSDt71+Qcug W5WDwoVfrMcVbl+Kh4/N3o4GH5o8xsUHoEfZ9KpU7j+BuAuD+4adIaCS+YDsHpgmBxSM80htf2J /3ecwTIAnnIw5RIr9oIR8vO50HrqYjGhgUMor4CLKm+1iTGDYdQG7iW93fw/DHs1aPCm+hvQ2lv B6jm2W7tZTPLKITCndcE7agLTU6I= X-Received: by 2002:a05:600c:4ece:b0:49c:eded:44e with SMTP id 5b1f17b1804b1-49d175561bbmr12339485e9.7.1788791735535; Mon, 07 Sep 2026 07:35:35 -0700 (PDT) X-Received: by 2002:a05:600c:4ece:b0:49c:eded:44e with SMTP id 5b1f17b1804b1-49d175561bbmr12339225e9.7.1788791735118; Mon, 07 Sep 2026 07:35:35 -0700 (PDT) Received: from localhost (128.223.159.143.dyn.plus.net. [143.159.223.128]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d03543064sm224260585e9.13.2026.09.07.07.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 07:35:34 -0700 (PDT) From: Andrew Burgess To: Rainer Orth , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH] Reduce gdb.base/many-headers.c iterations on Solaris [PR34555] In-Reply-To: References: Date: Mon, 07 Sep 2026 15:35:33 +0100 Message-ID: <87ik4hqgcq.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xafHJjb9dK229wgpeVHiMIoz5EyzolOFtryuvvDaBnM_1788791736 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Rainer Orth writes: GDB doesn't usually place bug IDs in the subject line as you're doing here. Instead bugs should be mentioned in the text, as you do, using the 'PR component/number' syntax, then there should be a 'Bug: URL' tag added at the end of the commit message. > As detailed in PR corefiles/34555, when reading the core file in the > gdb.base/many-headers.exp test, gdb consumes excessive amounts of memory > on Solaris. If left unchecked, e.g. with ulimit -Sv 8388608, the test > will consume all available swap space. Since Solaris doesn't do lazy > allocation, this will cause the system to become unusably slow. > > To avoid this, this patch reduces the iteration count by a factor of 100. My issue with this change is that the point of the test is to create many headers. If we reduce the header count then the test is no longer doing what it says it is, and the whole test becomes, well, pointless. I wonder if it would be better to just add this near the top of the test script: if {[istarget "*-*-solaris*"]} { # The Solaris core file reader consumes excessive memory with many # program headers (PR corefiles/34555). kfail gdb/34555 $gdb_test_file_name return } While looking at this I spotted that gdb.base/bigcore.exp already bails out early for Solaris, I wonder if this is the same underlying issue? The bug number mentioned in bigcore.exp (gdb/1551) is, I think, from pre-bugzilla days, so I've not been able to track that to an actual bug I could look at. > > Tested on sparcv9-sun-solaris2.11, x86_64-pc-solaris2.11, and > x86_64-pc-linux-gnu. > > Ok for trunk and the gdb-18 branch? > > > AFAICT, the issue is purely in gdb's Solaris corefile reader, which > seems to need a complete rewrite rather than a couple of bugfixes. Having touched lots of core file stuff recently, I'd be interested to know more about where exactly the problem is. Thanks, Andrew