From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +0+nA/pJqGrbuwwAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 15:24:42 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=tYxgCqJv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EE9601E066; Mon, 14 Sep 2026 15:24:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 674B01E033 for ; Mon, 14 Sep 2026 15:24:41 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 720094B9DB4E for ; Mon, 14 Sep 2026 19:24:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 720094B9DB4E Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=tYxgCqJv Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 4A5C84B99F65 for ; Mon, 14 Sep 2026 19:24:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A5C84B99F65 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A5C84B99F65 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789413856; cv=none; b=vvC7dtNKNtqjcsBgMh8MthMzvyaxFKu6E8RPcd4sYiMa+wphPLCuD7cOuiTwS2x5Ygz1LQKCSSbyzz/fezxq3li0+S41pxIPZyCrDfyNWIhzdJMw/OkUJ5JRXOAV2xermtRCGXDp5eVpijESwOIecOyOf5Yp1g7iaftfGLC33oA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789413856; c=relaxed/simple; bh=EHBkvrMaTFqCPaSjishA/2o8q23MGmfpvA8fMnUXnSo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ku0/DWtXUBo28XUb2XhQjJyXYEaTNIVfhhD0uLwS+xOGAJuGJYuB1E+kb8+ilbVvmorrLe/cFnlaAyMb1sic1Etg2BPHvAGUCyTsvd+TIJHoibOmOCz6qHryGWVcjH7soJJQSs0yu+GfnPm6hxFL6FH0FEMLMDbFGjlf3FEsvvA= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=tYxgCqJv reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A5C84B99F65 Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id 6AzkxSxfHJFmF6CHnxdGuj; Mon, 14 Sep 2026 19:24:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 6CHlxpBrcMSoY6CHlxf1tL; Mon, 14 Sep 2026 19:24:13 +0000 X-Authority-Analysis: v=2.4 cv=E9TNpbdl c=1 sm=1 tr=0 ts=6aa849df a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=rUvgzh4Chp54OCIPDmIA:9 a=ZXulRonScM0A:10 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a2SZE1InS9w6LqS0uMTK3BfmwgP3YXyAVA9hpzlC/rk=; b=tYxgCqJv9hq+azPH+Ha6AWhpCN 4yuUAp8ICWC1x/wX5QIY8HnNTvGZPa1k55/fx/v39ktFyJUJnIUKIM1n2jJ11TyukXRIAJokyjgGo 7hDGHYQpP1qcfyDQavL+GYdo4; Received: from 75-166-229-74.hlrn.qwest.net ([75.166.229.74]:58742 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x6CHk-00000000Q38-38VQ; Mon, 14 Sep 2026 13:24:12 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] gdb/python: check for nullptr before calling evpy_add_attribute In-Reply-To: <20260914191908.557014-1-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 14 Sep 2026 15:19:01 -0400") References: <20260914191908.557014-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Mon, 14 Sep 2026 13:24:11 -0600 Message-ID: <87ik47ws9w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.229.74 X-Source-L: No X-Exim-ID: 1x6CHk-00000000Q38-38VQ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-229-74.hlrn.qwest.net (bapiya) [75.166.229.74]:58742 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBodn9GOOlXLtxIH816etUFVA6oijoDN9wqx0pWmw+FBT8FhEz4a4QmvgxxGLjW8b0walfqzilaETAEppkcZfsmwGc+DyMsZbE6gAX7HiA1pyUmwQQD1 bKH2CoHmUHfbOARi8e0LCrXr5vCcQ2GmG0CUCsGXjj8YlMaDJDitYdn9skJqxwplnRd9wLp+aDNzj1quyYjfW996gjQZR1ZOzV8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> Found by Claude while I was reviewing some patches: gdbpy_borrowed_ref's Simon> constructor asserts that the object is not nullptr. Some call sites can Simon> in theory pass nullptr (although very unlikely, only on memory Simon> allocation failure kind of errors), fix them. It's an oversight that these weren't already checked, and probably they are all latent bugs. This is the kind of thing the safety API prevents, but (1) that's mostly on hold pending Longo's work; and (2) we aren't really ready to switch over the event stuff fully anyway (or at least for me it's one of the last things to do). Approved-By: Tom Tromey Tom