From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: FYI: fix some performance bugs with .gdb_index
Date: Mon, 20 Feb 2012 22:01:00 -0000 [thread overview]
Message-ID: <87haylurjh.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120220205336.GB15256@host2.jankratochvil.net> (Jan Kratochvil's message of "Mon, 20 Feb 2012 21:53:36 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> On Mon, 20 Feb 2012 21:42:28 +0100, Tom Tromey wrote:
>> + visited_found = htab_create_alloc (10,
>> + htab_hash_pointer, htab_eq_pointer,
>> + NULL, xcalloc, xfree);
Jan> [...]
>> + visited_not_found = htab_create_alloc (10,
>> + htab_hash_pointer, htab_eq_pointer,
>> + NULL, xcalloc, xfree);
Jan> [...]
>> + htab_t visited = htab_create_alloc (10, htab_hash_pointer, htab_eq_pointer,
>> + NULL, xcalloc, xfree);
Jan> Just wouldn't be obstack + hashtab_obstack_allocate more
Jan> appropriate here?
I don't think it would make a very big difference.
Tom
prev parent reply other threads:[~2012-02-20 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 20:44 Tom Tromey
2012-02-20 21:04 ` Jan Kratochvil
2012-02-20 22:01 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haylurjh.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox