From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30940 invoked by alias); 18 Apr 2012 14:57:36 -0000 Received: (qmail 30932 invoked by uid 22791); 18 Apr 2012 14:57:35 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Apr 2012 14:57:03 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3IEufPl005020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Apr 2012 10:56:41 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3IEud0T030284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 18 Apr 2012 10:56:40 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: RFC: bfd_section should not be NULL in call to prim_record_minimal_* References: <1334610821-10974-1-git-send-email-brobecker@adacore.com> <87zkaawp9g.fsf@fleche.redhat.com> <20120417151549.GN2852@adacore.com> <87obqqv13b.fsf@fleche.redhat.com> <20120417231206.GQ2852@adacore.com> Date: Wed, 18 Apr 2012 15:01:00 -0000 In-Reply-To: <20120417231206.GQ2852@adacore.com> (Joel Brobecker's message of "Tue, 17 Apr 2012 16:12:06 -0700") Message-ID: <87hawhqeag.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00583.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> So I tested your patch using AdaCore's testsuite, which shows that Joel> it fixes the problem as well, with no unexpected failures. And since Joel> this patch affects all platforms, I also tested it against the Joel> official testsuite on x86_64-linux. No regression either. Joel> So I think your patch is good to go. Thanks Joel. I'm checking it in now, with this ChangeLog entry: 2012-04-18 Tom Tromey * linespec.c (convert_linespec_to_sals): Don't use SYMBOL_OBJ_SECTION. (compare_msymbols): Arguments are minsym_and_objfile, not minimal_symbol*. Don't use SYMBOL_OBJ_SECTION. Tom