From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-90498-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24935 invoked by alias); 27 Apr 2012 19:47:47 -0000
Received: (qmail 24926 invoked by uid 22791); 27 Apr 2012 19:47:46 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Apr 2012 19:47:34 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3RJlYso028844	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 27 Apr 2012 15:47:34 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3RJlXpl019155	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 27 Apr 2012 15:47:33 -0400
From: Tom Tromey <tromey@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4 v3] Documentation and testsuite changes
References: <m3sjfvuk08.fsf@redhat.com> <m3bomjujpm.fsf@redhat.com>
Date: Fri, 27 Apr 2012 19:58:00 -0000
In-Reply-To: <m3bomjujpm.fsf@redhat.com> (Sergio Durigan Junior's message of	"Mon, 23 Apr 2012 01:59:33 -0300")
Message-ID: <87haw52bzf.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg01033.txt.bz2

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> +# Run the tests.  We run the tests two different ways: once with a
Sergio> +# plain probe, and once with a probe that has an associated semaphore.
Sergio> +# This returns -1 on failure to compile or start, 0 otherwise.
Sergio> +proc stap_test {{arg ""}} {
[...]
Sergio> +proc stap_test_no_debuginfo {{ arg "" }} {
Sergio> +    global testfile hex
Sergio> +
Sergio> +    if {[prepare_for_testing ${testfile}.exp ${testfile} ${testfile}.c \
[...]

I think it would be preferable if each different set of tests used a
different name for the built executable.  This sort of thing makes it
simpler to debug failing tests.  Also I think it is a newly agreed-upon
convention.

Sergio> diff --git a/gdb/testsuite/gdb.trace/stap-trace.exp b/gdb/testsuite/gdb.trace/stap-trace.exp
[...]
Sergio> +proc compile_stap_bin {{ arg "" }} {
[...]
Sergio> +    if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
Sergio> +	    executable [concat $arg debug nowarnings]] != "" } {

Same here.

Tom