From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92742-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3895 invoked by alias); 15 Jul 2012 02:18:09 -0000
Received: (qmail 3885 invoked by uid 22791); 15 Jul 2012 02:18:08 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 Jul 2012 02:17:57 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6F2Hcgg019894	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Sat, 14 Jul 2012 22:17:38 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6F2HaLw030749	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Sat, 14 Jul 2012 22:17:37 -0400
From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Doug Evans <dje@google.com>, dj@redhat.com, gcc-patches@gcc.gnu.org,        gdb-patches@sourceware.org
Subject: Re: [RFA libiberty, gdb] Add hashtab support to filename_ncmp.c and use it in gdb.
References: <20120709181015.2FCA41E13A1@ruffy2.mtv.corp.google.com>	<CADPb22Q=qT4AHoOo8cT1joKFziZqkzNFFTTP76_WDarV6mS+zg@mail.gmail.com>	<201207131921.q6DJLf5t002291@greed.delorie.com>	<CADPb22Q-k52YCUO72y+Wvew8Z+1vvjz5fwQVPQdhWsvkiugSeg@mail.gmail.com>	<83a9z3a1f5.fsf@gnu.org>	<CADPb22T0bdYcN+JHK+7+0m+4tQ_PPFwZcj=esf+J2-9nTPU+tQ@mail.gmail.com>	<831ukeam18.fsf__35820.0409253643$1342247693$gmane$org@gnu.org>
Date: Sun, 15 Jul 2012 02:18:00 -0000
In-Reply-To: <831ukeam18.fsf__35820.0409253643$1342247693$gmane$org@gnu.org>	(Eli Zaretskii's message of "Sat, 14 Jul 2012 09:34:27 +0300")
Message-ID: <87hat9939b.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00198.txt.bz2

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> I understand all that, but why would the eq_f function need to be an
Eli> external function on its own?

It is just to avoid other users having to write their own.

Eli> E.g., if we were to write a qsort replacement, would we have a
Eli> suitable string comparison function declared extern, when it is a
Eli> trivial wrapper around strcmp?

Yes.

We have streq for this, for use in hash tables and elsewhere.  It would
have been better if this were in libiberty, since currently there is a
copy of this function in gdb and like 3 or 4 in gcc.

Tom