From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92847-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9562 invoked by alias); 18 Jul 2012 20:25:01 -0000
Received: (qmail 9544 invoked by uid 22791); 18 Jul 2012 20:25:01 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jul 2012 20:24:47 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6IKOkkB004409	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 18 Jul 2012 16:24:46 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6IKOjp3032249	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 18 Jul 2012 16:24:46 -0400
From: Tom Tromey <tromey@redhat.com>
To: dje@google.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Create utils.h and host-defs.h, move gdb_vecs.h to common.
References: <yjt2liiimfik.fsf@ruffy2.mtv.corp.google.com>
Date: Wed, 18 Jul 2012 20:25:00 -0000
In-Reply-To: <yjt2liiimfik.fsf@ruffy2.mtv.corp.google.com> (dje@google.com's	message of "Tue, 17 Jul 2012 11:03:31 -0700")
Message-ID: <87hat424xe.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00303.txt.bz2

>>>>> "Doug" == Douglas Evans <dje@google.com> writes:

Doug> It's just a code reorg:
Doug> - creates utils.h and moves (almost) all the utils.c decls there from defs.h.
Doug>   I left QUIT&co in defs.h.
Doug> - moves gdb_vecs.h to common and creates common/gdb_vecs.c.
Doug>   I have a followup patch that uses gdb_vecs.c functions in gdbserver.
Doug> - creates common/host-defs.h, DIRNAME_SEPARATOR is needed by gdb_vecs.c.
Doug> - moves probe_p out of gdb_vecs.h, I think a better place for it is probe.h.

It all seems reasonable to me.

Tom