From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94652-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31247 invoked by alias); 18 Sep 2012 19:21:12 -0000
Received: (qmail 31238 invoked by uid 22791); 18 Sep 2012 19:21:11 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Sep 2012 19:20:58 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8IJKtZk017571	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 18 Sep 2012 15:20:56 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8IJKsXm003542	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 18 Sep 2012 15:20:55 -0400
From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Sanjoy Das <sanjoy@playingwithpointers.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects.
References: <1347942847-31510-1-git-send-email-sanjoy@playingwithpointers.com>	<1347942847-31510-3-git-send-email-sanjoy@playingwithpointers.com>	<83obl324vf.fsf@gnu.org>
Date: Tue, 18 Sep 2012 19:21:00 -0000
In-Reply-To: <83obl324vf.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 18 Sep	2012 09:59:32 +0300")
Message-ID: <87haqvw31l.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00375.txt.bz2

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

>> +  if (args[0] == '/')

Eli> Why not use IS_ABSOLUTE_PATH here?  That would make the code more
Eli> portable.

I agree.  The code bits are ok with that change.

Tom