From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96803-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9036 invoked by alias); 10 Dec 2012 20:20:46 -0000
Received: (qmail 9020 invoked by uid 22791); 10 Dec 2012 20:20:41 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Dec 2012 20:20:35 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBAKKVDH023497	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 10 Dec 2012 15:20:34 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBAKKImP016832	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 10 Dec 2012 15:20:22 -0500
From: Tom Tromey <tromey@redhat.com>
To: ali_anwar <ali_anwar@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: Updated patch for Bug 13217 - thread apply all detach throws a SEGFAULT
References: <5062EA9B.1060505@codesourcery.com>	<871uhnwkf3.fsf@fleche.redhat.com> <50C62BBB.6010404@codesourcery.com>
Date: Mon, 10 Dec 2012 20:20:00 -0000
In-Reply-To: <50C62BBB.6010404@codesourcery.com> (ali anwar's message of "Mon,	10 Dec 2012 23:36:43 +0500")
Message-ID: <87hantek1p.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00276.txt.bz2

>>>>> "Ali" == ali anwar <ali_anwar@codesourcery.com> writes:

Ali> +  if (thread_count ())
Ali> +    {
Ali> +      struct thread_info tp_array [thread_count ()];

You can't use variable-length arrays in gdb.
Probably xmalloc and a cleanup is your best option here.

Ali> +      for(k = 0; k != i; k++)

Space between 'for' and '('.

Ali> +            switch_to_thread ((&tp_array [k])->ptid);

No space before '['.  This occurs in a couple places.

Tom