From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97025-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29748 invoked by alias); 14 Dec 2012 14:14:38 -0000
Received: (qmail 29739 invoked by uid 22791); 14 Dec 2012 14:14:37 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Dec 2012 14:14:29 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBEEEQXn025948	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 14 Dec 2012 09:14:26 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBEEEOIY007801	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 14 Dec 2012 09:14:25 -0500
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'Pedro Alves'" <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix other memory leak in solib_target_current_sos
References: <50c9b7e6.25f2440a.3810.3771SMTPIN_ADDED_BROKEN@mx.google.com>	<50CA3784.2030706@redhat.com>	<000301cdd9d0$0db345d0$2919d170$@muller@ics-cnrs.unistra.fr>	<50CAF521.3040307@redhat.com>	<43198.6185875305$1355480794@news.gmane.org>
Date: Fri, 14 Dec 2012 14:14:00 -0000
In-Reply-To: <43198.6185875305$1355480794@news.gmane.org> (Pierre Muller's	message of "Fri, 14 Dec 2012 11:25:57 +0100")
Message-ID: <87hano3em7.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00498.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>    library_list = solib_target_parse_libraries (library_document);
Pierre>    if (library_list == NULL)
Pierre> -    return NULL;
Pierre> +    {
Pierre> +      xfree (library_document);
Pierre> +      return NULL;
Pierre> +    }

It seems to me that you could unconditionally free it here, before the if.

Tom