From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15036 invoked by alias); 16 Jan 2014 14:34:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15021 invoked by uid 89); 16 Jan 2014 14:34:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2014 14:34:07 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0GEY3Xq008082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Jan 2014 09:34:03 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0GEY1lk015793 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 16 Jan 2014 09:34:01 -0500 From: Tom Tromey To: Iain Buclaw Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion References: <871u0h9g41.fsf@fleche.redhat.com> <8738kv7o9y.fsf@fleche.redhat.com> Date: Thu, 16 Jan 2014 14:34:00 -0000 In-Reply-To: (Iain Buclaw's message of "Thu, 16 Jan 2014 10:59:04 +0000") Message-ID: <87ha94ngh3.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00608.txt.bz2 >>>>> "Iain" == Iain Buclaw writes: Iain> Is there anything else needed to be done from me? Just asking as I Iain> noticed a change to the way that requires this patch to be updated. I wasn't keeping score, but if all the patches are approved, you can rebase (our git repository rejects merge commits on master), merge to master, and push. If a patch needs any changes during the rebase, you can use your judgment -- if it is just a trivial change, post the updated patch as an FYI; if it required some work, usually another round of review is needed. If you don't have write-after-approval access, now is a good time to get it :). Send me email off-list and I will hook you up. Tom