Re: [RFC PATCH 0/3] Catch syscall group

Gabriel Krisman Bertazi
2014-10-12T21:12:33Z

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

Sergio Durigan Junior <sergiodj@redhat.com> writes:

> On Tuesday, October 07 2014, Gabriel Krisman Bertazi wrote:
>
>> Hello,
>>
>> This multi-part patch implements on top of the 'catch syscall' command
>> the ability to catch a group of related syscalls using a single
>> command.
>
Sergio and Doug,

Thank you both for your review.

>> (Please note that adding this feature to GDB was first suggested by Tom
>> Tromey on PR 15879. :-)
>> <https://sourceware.org/bugzilla/show_bug.cgi?id=15879>).
>
> It is good to mention the bug in the ChangeLog, even if you are not
> directly fixing it.

Ok.

> I will make comments in the patch itself, but it would be nice if you
> could do that for the other existing XML files as well. You didn't
> mention if you intend to do so or not.
>
> I know it will be kind of boring, but unfortunately those XML files are
> not being really maintained nowadays (a problem I intend to address soon
> with some patches and proposals), so if you don't touch those files now
> they will probably be forgotten for quite some time...
>
> However, this is just a request, so if you don't have the time to do
> that now I'd still vote for including this feature on GDB.

I intend to do so for other architectures, but forgot to mention in my
original message. Still, I won't be able to test on some platforms.

Thanks.

--
Gabriel Krisman Bertazi

[-- Attachment #2: Type: application/pgp-signature, Size: 818 bytes --]