From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15287 invoked by alias); 12 Jan 2015 04:43:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15267 invoked by uid 89); 12 Jan 2015 04:43:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 12 Jan 2015 04:43:10 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0C4h70N028249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 11 Jan 2015 23:43:07 -0500 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0C4h69R011189 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Sun, 11 Jan 2015 23:43:07 -0500 From: Sergio Durigan Junior To: Pedro Alves Cc: "Breazeal\, Don" , Yao Qi , gdb-patches@sourceware.org Subject: [regression/native-gdbserver][buildbot] Python testscases get staled (was: Re: [PATCH] skip "attach" tests when testing against stub-like targets) References: <1418748834-27545-1-git-send-email-palves@redhat.com> <1418748834-27545-6-git-send-email-palves@redhat.com> <87wq5qsfaf.fsf@codesourcery.com> <54921989.4060005@redhat.com> <54AADFA1.9040003@codesourcery.com> <54AD5BFC.2030906@redhat.com> <54AFBA7B.6040403@redhat.com> X-URL: http://blog.sergiodj.net Date: Mon, 12 Jan 2015 04:43:00 -0000 In-Reply-To: <54AFBA7B.6040403@redhat.com> (Pedro Alves's message of "Fri, 09 Jan 2015 11:24:43 +0000") Message-ID: <87h9vwpq1x.fsf_-_@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00288.txt.bz2 On Friday, January 09 2015, Pedro Alves wrote: > On 01/07/2015 04:17 PM, Pedro Alves wrote: >> On 01/05/2015 07:01 PM, Breazeal, Don wrote: >>>> # Start a set of programs running and then wait for a bit, to be sure >>>> # that they can be attached to. Return a list of the processes' PIDs. >>>> >>>> proc spawn_wait_for_attach { executable_list } { >>>> set pid_list {} >>>> >>>> + if ![can_spawn_for_attach] { >>>> + error "can't spawn for attach with this target/board" >>>> + } >>> >>> Should this be calling "error", or should it call something like >>> "untested" or "unsupported", since it isn't expected to work in these cases? >> >> The idea is that all .exp files that use spawn_wait_for_attach >> would have already checked can_spawn_for_attach early, and skipped the >> tests if false. That makes is a test bug to see a call to >> spawn_wait_for_attach if can_spawn_for_attach is false. >> >> I should have really split those hunks out to a separate patch and >> added calls to can_spawn_for_attach in all tests that are using >> spawn_wait_for_attach already. Like below. WDYT? >> >> (There are probably other attach tests that don't use >> spawn_wait_for_attach that need the can_spawn_for_attach too. >> We can do this incrementally.) > > I went ahead and pushed this to unblock the parent series. Hey Pedro, Buildbot (which is running only internally so far, but will hopefully be deployed this week) "caught" this when building in x86_64 (Fedora 21) and testing the native-gdbserver variant (both x86_64 and x86). When you run the test on the gdb.python/ directory, you see that it stales when it reaches the gdb.python/py-section-script.exp testcase. Buildbot's gdb.log specifically has: Running ../../../binutils-gdb/gdb/testsuite/gdb.python/py-section-script.exp ... ERROR: (timeout) GDB never initialized after 10 seconds. ERROR: no fileid for gdbuild ERROR: Couldn't send python print ('test') to GDB. ERROR: no fileid for gdbuild ERROR: Couldn't send python print (sys.version_info[0]) to GDB. ERROR: no fileid for gdbuild ERROR: Couldn't send python print (sys.version_info[1]) to GDB. ERROR: no fileid for gdbuild ERROR: no fileid for gdbuild ... (this goes on and on, for several testcases) I still did not debug this (intend to do so tomorrow, if you don't see this before I start my day), but running a simple git-bisect showed me that this specific commit is the culprit. Cheers, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/