From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32793 invoked by alias); 30 Oct 2016 03:18:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28516 invoked by uid 89); 30 Oct 2016 03:16:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:4.86_1, H*F:U*tom, H*RU:10.0.90.82, Hx-spam-relays-external:10.0.90.82 X-HELO: gproxy1.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 30 Oct 2016 03:16:21 +0000 Received: from CMOut01 (cmgw2 [10.0.90.82]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 6D791176820 for ; Sat, 29 Oct 2016 21:08:09 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 1f841u0142f2jeq01f87ux; Sat, 29 Oct 2016 21:08:07 -0600 X-Authority-Analysis: v=2.1 cv=beT4Do/B c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=BzObnAOqAAAA:8 a=MKoJRZBYnurn36-tAQ8A:9 a=PuSIgb6VMkSJ0_1bSHE4:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:58680 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c0gTe-0002hB-3O; Sat, 29 Oct 2016 21:08:06 -0600 From: Tom Tromey To: Manish Goregaokar Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] Add support for the sizeof function in Rust References: Date: Sun, 30 Oct 2016 03:18:00 -0000 In-Reply-To: (Manish Goregaokar's message of "Sat, 29 Oct 2016 06:10:11 -0700") Message-ID: <87h97uwn3f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1c0gTe-0002hB-3O X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya) [174.16.143.211]:58680 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00845.txt.bz2 >>>>> "Manish" == Manish Goregaokar writes: Manish> `sizeof` is a keyword so Rust functions by Manish> that name cannot exist. Thanks, that answers my major concern. Manish> The expression could be `sizeof foo` instead of `sizeof(foo)`. I feel Manish> the latter is better because it's closer to how `mem::size_of` works. I agree. This patch is ok. Thanks. Tom