From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26659 invoked by alias); 20 Dec 2016 18:05:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26642 invoked by uid 89); 20 Dec 2016 18:05:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_20,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*tom, H*r:cmgw3, tromey.com, H*RU:sk:gproxy5 X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 20 Dec 2016 18:05:05 +0000 Received: (qmail 30128 invoked by uid 0); 20 Dec 2016 18:05:04 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy5.mail.unifiedlayer.com with SMTP; 20 Dec 2016 18:05:04 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id NJ4z1u0172f2jeq01J52SE; Tue, 20 Dec 2016 11:05:02 -0700 X-Authority-Analysis: v=2.1 cv=G8WPTbU5 c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n5n_aSjo0skA:10 a=20KFwNOVAAAA:8 a=-QdxyGB3gQhRyiVaghsA:9 a=GfdQIapxcokA:10 a=e_O65bzb51kRm2y5VmPK:22 Received: from 75-171-175-27.hlrn.qwest.net ([75.171.175.27]:56118 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cJOmZ-00039j-Ce; Tue, 20 Dec 2016 11:04:59 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [pushed] gdb: Constify solib_find (Re: [RFA 2/8] Use class to manage BFD reference counts) References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-3-git-send-email-tom@tromey.com> <87fulseza9.fsf@tromey.com> Date: Tue, 20 Dec 2016 18:05:00 -0000 In-Reply-To: (Pedro Alves's message of "Tue, 20 Dec 2016 17:18:57 +0000") Message-ID: <87h95ywk6t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cJOmZ-00039j-Ce X-Source-Sender: 75-171-175-27.hlrn.qwest.net (pokyo) [75.171.175.27]:56118 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-12/txt/msg00360.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Tom> I did this, but it's a bit ugly as solib_find isn't const-correct. Pedro> That doesn't look hard to fix. I've pushed in the patch below. Pedro> What uglification does this allow removing? Huh. I had taken a stab at this but I thought I ran into some morass, so I stopped. Oh well. Anyway what this enables is a change from &str[0] to str.c_str(). Tom