From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29310 invoked by alias); 16 Feb 2017 00:57:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29263 invoked by uid 89); 16 Feb 2017 00:57:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Awesome, H*f:sk:afabaf9, Hx-languages-length:1616, Pushed X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Feb 2017 00:57:11 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C917F8123E; Thu, 16 Feb 2017 00:57:11 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1G0vBU7008383 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 15 Feb 2017 19:57:11 -0500 From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches , Doug Evans Subject: Re: [PATCH] PR gdb/21164: maint print {symbols,msymbols,psymbols} without args crash References: <20170215201548.29225-1-sergiodj@redhat.com> <87o9y3njyk.fsf@redhat.com> X-URL: http://blog.sergiodj.net Date: Thu, 16 Feb 2017 00:57:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 15 Feb 2017 23:06:19 +0000") Message-ID: <87h93vneai.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00432.txt.bz2 On Wednesday, February 15 2017, Pedro Alves wrote: > On 02/15/2017 10:54 PM, Sergio Durigan Junior wrote: >> On Wednesday, February 15 2017, Pedro Alves wrote: >> >>> On 02/15/2017 08:15 PM, Sergio Durigan Junior wrote: >>> >>>> This patch fixes that. OK to apply? >>> >>> Can you add some tests for this, please? >> >> How about this? > > Awesome, thanks! OK with minor nits. Thanks for the review. Pushed with all the minor nits fixed. 99e8a4f9f8832da0f37c6f35b11629b01897800d >> commit acd6597d63b2501588318466cd308701d09a58f3 >> Author: Sergio Durigan Junior >> Date: Wed Feb 15 15:08:19 2017 -0500 > >> Hi, > > ...remove this above... > >> This patch fixes that. OK to apply? > > ...and this "OK" from the commit log and... > >> diff --git a/gdb/testsuite/gdb.base/maint.exp b/gdb/testsuite/gdb.base/maint.exp >> index 2853508..b87cbfc 100644 >> --- a/gdb/testsuite/gdb.base/maint.exp >> +++ b/gdb/testsuite/gdb.base/maint.exp >> @@ -561,6 +561,14 @@ gdb_expect { >> >> #set timeout $oldtimeout >> >> +# Testing that the commands work without an argument. For this test, > > Write "Test that" here. > >> +# we don't need an inferior loaded/running. >> +# See PR gdb/21164. >> +gdb_exit >> +gdb_start >> +gdb_test_no_output "maint print symbols" >> +gdb_test_no_output "maint print msymbols" >> +gdb_test_no_output "maint print psymbols" > > Thanks, > Pedro Alves -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/