Re: [RFA v2 1/4] C++-ify break-catch-sig

Simon Marchi
2017-07-21T19:43:29Z

Hi Tom,

Two nits, in addition to what Sergio already pointed out.

> @@ -355,8 +314,8 @@ signal_catchpoint_explains_signal (struct
> breakpoint *b, enum gdb_signal sig)
> then internal signals like SIGTRAP are not caught. */
>
> static void
> -create_signal_catchpoint (int tempflag, VEC (gdb_signal_type) *filter,
> - int catch_all)
> +create_signal_catchpoint (int tempflag, std::vector<gdb_signal>
> &&filter,
> + bool catch_all)

The documentation of this function would need updating.

> {
> struct signal_catchpoint *c;
> struct gdbarch *gdbarch = get_current_arch ();
> @@ -373,57 +332,50 @@ create_signal_catchpoint (int tempflag, VEC
> (gdb_signal_type) *filter,
> /* Splits the argument using space as delimiter. Returns an xmalloc'd
> filter list, or NULL if no filtering is required. */
>
> -static VEC (gdb_signal_type) *
> -catch_signal_split_args (char *arg, int *catch_all)
> +static std::vector<gdb_signal>
> +catch_signal_split_args (char *arg, bool *catch_all)

The documentation of this function too.

Thanks,

Simon