From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76397 invoked by alias); 4 Aug 2017 17:13:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74882 invoked by uid 89); 4 Aug 2017 17:13:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy3-pub.mail.unifiedlayer.com Received: from gproxy3-pub.mail.unifiedlayer.com (HELO gproxy3-pub.mail.unifiedlayer.com) (69.89.30.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Aug 2017 17:13:15 +0000 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy3.mail.unifiedlayer.com (Postfix) with ESMTP id AF451401CB for ; Fri, 4 Aug 2017 11:13:14 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id t5DB1v00e2f2jeq015DEcz; Fri, 04 Aug 2017 11:13:14 -0600 X-Authority-Analysis: v=2.2 cv=epiv9shX c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=KeKAF7QvOSUA:10 a=SZ-M7xf712myPNPvuOwA:9 Received: from 75-166-24-97.hlrn.qwest.net ([75.166.24.97]:55514 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1ddg9v-003MJX-BA; Fri, 04 Aug 2017 11:13:11 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Use gdb::unique_xmalloc_ptr when calling tilde_expand References: <20170803214348.27356-1-tom@tromey.com> <87bmnv8n2y.fsf@tromey.com> Date: Fri, 04 Aug 2017 17:13:00 -0000 In-Reply-To: (Simon Marchi's message of "Fri, 04 Aug 2017 16:51:49 +0200") Message-ID: <87h8xncl3t.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1ddg9v-003MJX-BA X-Source-Sender: 75-166-24-97.hlrn.qwest.net (pokyo) [75.166.24.97]:55514 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-08/txt/msg00079.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> There is still a cleanup in reload_shared_libraries_1, so I don't Simon> think the do_cleanups should be removed. Ugh, sorry about that. That code is duplicating the bfd's file name. But I can't see why that's important. I think just removing the xstrdup and the make_cleanup is the right thing to do here. What do you think? Tom