From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15040 invoked by alias); 14 Aug 2017 15:22:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6115 invoked by uid 89); 14 Aug 2017 15:22:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=fears X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Aug 2017 15:22:47 +0000 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy6.mail.unifiedlayer.com (Postfix) with ESMTP id D5BB71E0BE8 for ; Mon, 14 Aug 2017 09:21:43 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id x3Mg1v00v2f2jeq013MjcG; Mon, 14 Aug 2017 09:21:43 -0600 X-Authority-Analysis: v=2.2 cv=FrR1xyjq c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=KeKAF7QvOSUA:10 a=20KFwNOVAAAA:8 a=kh0spQgjlUcoI9woA14A:9 Received: from 75-166-24-97.hlrn.qwest.net ([75.166.24.97]:53130 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dhHBU-003OXL-J1; Mon, 14 Aug 2017 09:21:40 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 1/2] Fix two regressions in scalar printing References: <20170713123400.28917-1-tom@tromey.com> <20170713123400.28917-2-tom@tromey.com> <22c48f9e-ec2c-850d-91d3-c6a3ea8cdb11@redhat.com> <871spjufnv.fsf@pokyo> <871sow9scp.fsf@tromey.com> <707a03e4-46ef-cea9-f098-cc687b02d31e@redhat.com> Date: Mon, 14 Aug 2017 15:22:00 -0000 In-Reply-To: <707a03e4-46ef-cea9-f098-cc687b02d31e@redhat.com> (Pedro Alves's message of "Mon, 14 Aug 2017 15:02:47 +0100") Message-ID: <87h8xauqd9.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dhHBU-003OXL-J1 X-Source-Sender: 75-166-24-97.hlrn.qwest.net (pokyo) [75.166.24.97]:53130 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-08/txt/msg00305.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Sorry for dropping the ball on this. I wanted to be sure that Pedro> we have tests for the Pedro> (gdb) p /u -1 Pedro> $1 = 4294967295 Pedro> (gdb) p /d (unsigned long long) -1 Pedro> $2 = -1 Pedro> etc. issues discussed earlier. Do you know whether there's some tests for Pedro> that already somewhere, but might have simply been missed before for Pedro> running both patches together? Good question. I think what happened is that this change had some fallout elsewhere, which is why there are also some test changes in the patch. However, these are kind of indirect, so I added tests for "print/d (unsigned char) -1" and "print/u (char) -1". >> +# Regression test for PR gdb/21675 >> +proc test_radices {} { >> + gdb_test "print/o 16777211" " = 077777773" >> + gdb_test "print/d 1.5" " = 1\[^.\]" >> + gdb_test "print/u 1.5" " = 1\[^.\]" Pedro> What's the reason for the "\[^.\]" part of the regexes? Pedro> What's that trying to match? Why not simply " = 1" ? I was worried that this would erroneously match "1.5" or the like; but I tried it and I see my fears are unfounded. So, I changed these to " = 1". Tom