From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19719 invoked by alias); 22 Sep 2017 17:30:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19608 invoked by uid 89); 22 Sep 2017 17:30:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS,TRACKER_ID autolearn=ham version=3.3.2 spammy=Hx-languages-length:1810 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 17:30:34 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75C064E4CB for ; Fri, 22 Sep 2017 17:30:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 75C064E4CB Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4EE25600CD; Fri, 22 Sep 2017 17:30:31 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH v3 2/5] Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)" References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-3-sergiodj@redhat.com> <584ed105-72a1-e0dc-ab25-a1c89d2b2dcd@redhat.com> Date: Fri, 22 Sep 2017 17:30:00 -0000 In-Reply-To: <584ed105-72a1-e0dc-ab25-a1c89d2b2dcd@redhat.com> (Pedro Alves's message of "Fri, 22 Sep 2017 12:19:00 +0100") Message-ID: <87h8vu4p55.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00683.txt.bz2 On Friday, September 22 2017, Pedro Alves wrote: > On 09/21/2017 11:59 PM, Sergio Durigan Junior wrote: >> >> gdb/ChangeLog: >> yyyy-mm-dd Sergio Durigan Junior >> >> * cli/cli-cmds.c (pwd_command): Use "getcwd (NULL, 0)". >> (cd_command): Likewise. Free "current_directory" before >> assigning to it. >> * main.c (captured_main_1): Use "getcwd (NULL, 0)". >> * mi/mi-cmd-env.c (mi_cmd_env_pwd): Likewise. >> * top.c (gdb_dirbuf): Remove global declaration. >> * top.h (gdb_dirbuf): Likewise. > > OK. And trying the new thing: > > Reviewed-by: Pedro Alves > > ... provided the nit below is addressed. AFAIU I had to add this to the commit log. I did this; if this wasn't correct, I apologize. >> diff --git a/gdb/mi/mi-cmd-env.c b/gdb/mi/mi-cmd-env.c >> index 977b6e274d..db87ead33d 100644 >> --- a/gdb/mi/mi-cmd-env.c >> +++ b/gdb/mi/mi-cmd-env.c >> @@ -73,12 +73,12 @@ mi_cmd_env_pwd (const char *command, char **argv, int argc) >> } >> >> /* Otherwise the mi level is 2 or higher. */ >> - >> - if (! getcwd (gdb_dirbuf, sizeof (gdb_dirbuf))) > > Please leave the empty line after the comment. That comment is > logically related to the code above, not the getcwd call. Done. >> + gdb::unique_xmalloc_ptr cwd (getcwd (NULL, 0)); >> + if (cwd == NULL) >> error (_("-environment-pwd: error finding name of working directory: %s"), >> safe_strerror (errno)); >> - >> - uiout->field_string ("cwd", gdb_dirbuf); >> + >> + uiout->field_string ("cwd", cwd.get ()); >> } > > Thanks, > Pedro Alves Pushed. 43573013c9836f2b91b74b9b29dac35fdb41e06b Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/