From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129759 invoked by alias); 19 Jan 2018 19:08:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129723 invoked by uid 89); 19 Jan 2018 19:08:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jan 2018 19:08:18 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0JJ8EJ1000831 for ; Fri, 19 Jan 2018 14:08:17 -0500 Received: from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fkndejv78-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 19 Jan 2018 14:08:16 -0500 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Jan 2018 12:08:16 -0700 Received: from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15) by e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 19 Jan 2018 12:08:12 -0700 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w0JJ8CSl14090640; Fri, 19 Jan 2018 12:08:12 -0700 Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0AED1BE039; Fri, 19 Jan 2018 12:08:12 -0700 (MST) Received: from pedro.localdomain (unknown [9.85.199.208]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id B974EBE038; Fri, 19 Jan 2018 12:08:11 -0700 (MST) Received: by pedro.localdomain (Postfix, from userid 1000) id C3DE73C5619; Fri, 19 Jan 2018 17:08:08 -0200 (-02) From: Pedro Franco de Carvalho To: Nikola Prica , Kevin Buettner Cc: gdb-patches@sourceware.org, "Ananthakrishna Sowda \(asowda\)" , "Ivan Baev \(ibaev\)" , "'Nemanja Popov'" , Djordje Todorovic , Ulrich.Weigand@de.ibm.com Subject: Re: [PING][PATCH] Fix for prologue processing on PowerPC In-Reply-To: <90e3f502-7d22-d22e-4bf0-3b0db43347d6@rt-rk.com> References: <20171108095850.394a48ca@pinnacle.lan> <8bf0014c-e83c-5988-4d06-173572f21186@rt-rk.com> <7ba16b14-9384-34d9-937e-531a2192842a@linux.vnet.ibm.com> <87608p4dgr.fsf@linux.vnet.ibm.com> <87r2qx4oit.fsf@linux.vnet.ibm.com> <20038806-69e5-b7ce-479b-54185089145b@rt-rk.com> <90e3f502-7d22-d22e-4bf0-3b0db43347d6@rt-rk.com> Date: Fri, 19 Jan 2018 19:08:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18011919-0028-0000-0000-0000090A7EB2 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008406; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000247; SDB=6.00977405; UDB=6.00495554; IPR=6.00757312; MB=3.00019133; MTD=3.00000008; XFM=3.00000015; UTC=2018-01-19 19:08:14 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18011919-0029-0000-0000-0000393BDE2D Message-Id: <87h8rh8y5j.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-19_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801190248 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00413.txt.bz2 Hello Nikola, Is that the version you meant to send? That looks like the same as this one: https://sourceware.org/ml/gdb-patches/2017-11/msg00207.html Thanks, Pedro Nikola Prica writes: > Hi Pedro, > > I've just seen that changed version of patch was not attached. > > Best regards, > > Nikola Prica > From 3564cd3be620bb39ca615919148fa0d949284d35 Mon Sep 17 00:00:00 2001 > From: Prica > Date: Thu, 9 Nov 2017 13:10:48 +0100 > Subject: [PATCH] Fix for prologue processing on PowerPC > > One of conditions in skip_prologue() is never visited because it > expects non shifted `lr_reg`. That condition is supposed to set PC > offset. When body of this condition is visited PC offset is set and > there will be no need to look for it in next frames nor to use frame > unwind directives. > > gdb/ChangeLog: > *rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg > and assign shifted lr_reg to fdata->lr_register when lr_reg is > set. If iteration do not hit lim_pc lr_register is set as -1. > --- > gdb/rs6000-tdep.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c > index 6c44995..6f05ef5 100644 > --- a/gdb/rs6000-tdep.c > +++ b/gdb/rs6000-tdep.c > @@ -1655,9 +1655,12 @@ skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc, CORE_ADDR lim_pc, > remember just the first one, but skip over additional > ones. */ > if (lr_reg == -1) > - lr_reg = (op & 0x03e00000) >> 21; > - if (lr_reg == 0) > - r0_contains_arg = 0; > + { > + lr_reg = (op & 0x03e00000); > + fdata->lr_register = lr_reg >> 21; > + if (lr_reg == 0) > + r0_contains_arg = 0; > + } > continue; > } > else if ((op & 0xfc1fffff) == 0x7c000026) > @@ -2180,8 +2183,8 @@ skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc, CORE_ADDR lim_pc, > } > #endif /* 0 */ > > - if (pc == lim_pc && lr_reg >= 0) > - fdata->lr_register = lr_reg; > + if (pc != lim_pc) > + fdata->lr_register = -1; > > fdata->offset = -fdata->offset; > return last_prologue_pc; > -- > 2.7.4