From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99216 invoked by alias); 26 Feb 2018 19:38:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99167 invoked by uid 89); 26 Feb 2018 19:38:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=states X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 19:38:00 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 5A7E24015D795 for ; Mon, 26 Feb 2018 13:37:58 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qOb0ettN8cGlpqOb0ep5n2; Mon, 26 Feb 2018 13:37:58 -0600 Received: from 174-29-60-18.hlrn.qwest.net ([174.29.60.18]:40594 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eqOaz-002rkI-Vy; Mon, 26 Feb 2018 13:37:58 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Change target_write_memory_blocks to use std::vector References: <20180225173703.6675-1-tom@tromey.com> <05afbce6-b052-9cb4-d4bc-c392f992ab60@simark.ca> Date: Mon, 26 Feb 2018 19:38:00 -0000 In-Reply-To: <05afbce6-b052-9cb4-d4bc-c392f992ab60@simark.ca> (Simon Marchi's message of "Sun, 25 Feb 2018 17:26:03 -0500") Message-ID: <87h8q3pmnf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eqOaz-002rkI-Vy X-Source-Sender: 174-29-60-18.hlrn.qwest.net (pokyo) [174.29.60.18]:40594 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-02/txt/msg00400.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> + load_section_data () >> + { >> + } Simon> Is this empty constructor needed? I only added it for clarity. Is there some standard approach to this? Or a gdb standard? Simon> Actually, I think it would be nice to give constructors to the data Simon> structures when possible, to make it less likely to have them in Simon> invalid states. Simon> Here's an example, you can integrate it in your patch if you like it. Yeah, this seems better to me. I will pull it in. Tom