From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7461 invoked by alias); 12 Apr 2018 18:10:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7412 invoked by uid 89); 12 Apr 2018 18:10:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=hadnt X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.46.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Apr 2018 18:09:59 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 922CA400D7931 for ; Thu, 12 Apr 2018 13:09:58 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 6gfWftMOc6il36gfWfwl54; Thu, 12 Apr 2018 13:09:58 -0500 Received: from 75-166-37-45.hlrn.qwest.net ([75.166.37.45]:45624 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1f6gfW-001RoJ-AX; Thu, 12 Apr 2018 13:09:58 -0500 From: Tom Tromey To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: -readnow crash Rust regression [Re: [RFA v2 3/4] Convert Rust to use discriminated unions] References: <20180222203018.23551-1-tom@tromey.com> <20180222203018.23551-4-tom@tromey.com> <20180410203650.GA2496@host1.jankratochvil.net> <87lgduo3om.fsf@tromey.com> <20180411070402.GA16230@host1.jankratochvil.net> <87vacxle14.fsf@tromey.com> Date: Thu, 12 Apr 2018 18:10:00 -0000 In-Reply-To: <87vacxle14.fsf@tromey.com> (Tom Tromey's message of "Wed, 11 Apr 2018 13:49:11 -0600") Message-ID: <87h8ognvnu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1f6gfW-001RoJ-AX X-Source-Sender: 75-166-37-45.hlrn.qwest.net (bapiya) [75.166.37.45]:45624 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00232.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> I have a hack to fix that but it reveals another problem, which is that Tom> some of the type rewriting can be done multiple times, causing other bugs. Tom> I hadn't considered this possibility. I'm looking into a good way to Tom> fix it. This analysis was mistaken, and it turned out to be simpler -- good news. I will send out my patches, but writing a test case for 23010 seems quite painful. Based on the stack trace I got, and investigating the DWARF of the reproducer, you need: * A partial CU with no language, which has a function that has some parameters * A full C++ CU that references that function using DW_AT_abstract_origin In the webkit reproducer this DW_AT_abstract_origin occurs in an inlined function IIRC. Tom