From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107152 invoked by alias); 8 Sep 2018 13:16:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107072 invoked by uid 89); 8 Sep 2018 13:16:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.198.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Sep 2018 13:16:26 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 17189400CAA42 for ; Sat, 8 Sep 2018 07:21:09 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id yd5qfTj7NbXuJyd61fnNjX; Sat, 08 Sep 2018 08:16:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7Fx2l9TYsxYG9RVmv6RJK+dDQh5fMVsAcYpTcozuy7E=; b=DybdaHBoqICZuz4ExijTVieTHw XZy3V0qKEZy0weN5+n1d/OiIT85oF6v7B6bCjkfgZ7Pu9IgqG89eMWhEIcAQHh2r2IoVi+IH+Yayt 7eDu0WOxSe1qqJ33dS1jnD5j6; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:41574 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fyd5p-000rd3-KE; Sat, 08 Sep 2018 08:16:05 -0500 From: Tom Tromey To: John Darrington Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] GDB: New target s12z References: <20180829141845.26378-1-john@darrington.wattle.id.au> <20180829141845.26378-5-john@darrington.wattle.id.au> <874lf1vuca.fsf@tromey.com> <20180908044605.ctlyone5vd4sx6jt@jocasta.intra> Date: Sat, 08 Sep 2018 13:16:00 -0000 In-Reply-To: <20180908044605.ctlyone5vd4sx6jt@jocasta.intra> (John Darrington's message of "Sat, 8 Sep 2018 06:46:05 +0200") Message-ID: <87h8j05duz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00163.txt.bz2 >>>>> "John" == John Darrington writes: Tom> Is this stuff useful? John> I suspect not. In fact, I'm very dubious about the whole John> skip_prologue_using_sal function. It seems to not work very well. John> + /* JPB: 28-Apr-11. This is a temporary patch, to get round GDB John> + crashing right at the beginning. Build the frame ID as best we John> + can. */ John> + trad_frame_set_id (info, frame_id_build (this_sp, this_pc)); Tom> Could you explain this more? John> I'm afraid I can't. This was code I took over from the or1k target. Ok; in that case I think you should drop these parts from the patch. Tom