From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52171 invoked by alias); 18 Sep 2018 21:23:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52158 invoked by uid 89); 18 Sep 2018 21:23:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:610 X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 21:23:54 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 3127EBD79B5 for ; Tue, 18 Sep 2018 16:23:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2NTCgjv6dbXuJ2NTIg1mmF; Tue, 18 Sep 2018 16:23:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TvuLQ318Wuu5Rzk/l/v37bvqTicHT/WVVU5B4dn6K94=; b=n6PHaZ98Yc+Boxc4cII9PCp7zc KFYvj5Uc+qTSsHZsuVf8yrFj5/oC1RxKHY7rhowA19i4ERdk2I5jAKwU8NXOgILxdsMexaSkY90OZ AFhXvV+T8Q6bGN5n4ZMbzA9mF; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:53418 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g2NTB-003KCM-OA; Tue, 18 Sep 2018 16:23:41 -0500 From: Tom Tromey To: Simon Marchi Cc: Xavier Roirand , gdb-patches@sourceware.org, brobecker@adacore.com Subject: Re: [RFA 2/5] Darwin: Handle unrelocated dyld. References: <1534932677-9496-1-git-send-email-roirand@adacore.com> <1534932677-9496-3-git-send-email-roirand@adacore.com> Date: Tue, 18 Sep 2018 21:23:00 -0000 In-Reply-To: (Simon Marchi's message of "Wed, 22 Aug 2018 09:59:13 -0400") Message-ID: <87h8imsdnn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00658.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> + if (start == 0) >> + notifier = 0; [...] >> + /* Add the breakpoint which is hit by dyld when the list of solib is >> + modified. */ >> + if (notifier != 0) >> + create_solib_event_breakpoint (target_gdbarch (), notifier); >> } Simon> Also, if the process of finding the notifier address fails at any Simon> point, could we display a warning? This is the one spot -- but I didn't know what to put in the comment, because I don't know the circumstances under which start==0 can happen. Tom