Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: "Павел Крюков" <kryukov@frtk.ru>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Do not expand macros to 'defined'
Date: Wed, 16 Jan 2019 20:49:00 -0000	[thread overview]
Message-ID: <87h8e89vmk.fsf@igel.home> (raw)
In-Reply-To: <4943ce6216667607c40b630ecba6a4d1@polymtl.ca> (Simon Marchi's	message of "Wed, 16 Jan 2019 15:02:23 -0500")

On Jan 16 2019, Simon Marchi <simon.marchi@polymtl.ca> wrote:

> The patch LGTM, I agree these macros are not really needed.  But I am
> confused, does this actually fix your c++ build?  You mentioned you were
> using g++ (and therefore cpp), which supposedly can handle this fine:
>
> https://gcc.gnu.org/onlinedocs/cpp/Defined.html
>
> If so, what did the error look like?

This has nothing to do with C vs. C++, both have the same wording:

    If the token defined is generated as a result of this replacement
    process or use of the defined unary operator does not match one of
    the two specified forms prior to macro replacement, the behavior is
    undefined.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."


  parent reply	other threads:[~2019-01-16 20:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16  6:34 Павел Крюков
2019-01-16 20:02 ` Simon Marchi
2019-01-16 20:38   ` Pavel Kryukov
2019-01-16 21:11     ` Simon Marchi
2019-01-16 20:49   ` Andreas Schwab [this message]
2019-01-16 20:59     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8e89vmk.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kryukov@frtk.ru \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox