From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104715 invoked by alias); 30 May 2019 13:20:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104689 invoked by uid 89); 30 May 2019 13:20:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 May 2019 13:20:47 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway24.websitewelcome.com (Postfix) with ESMTP id D870BEC11 for ; Thu, 30 May 2019 08:20:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id WKz6hu7IPiQerWKz6hUOQw; Thu, 30 May 2019 08:20:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c0UZFcvvDqoNyqluvdhgFWKfJbzXxroLrmvupNlCO4E=; b=ZaG4dOjrwf4qXSE+1YfHhAE8Vv ZEGOztbZauPZ6bewKqbITTSiLJI1DLBtfRxBdrVdCGXxsIgRd0mxNBaZiN+h/R5OIAbC5fJcSJNes 6ujEs+wuhKThC7CnsSlGK1IKM; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:48688 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hWKz6-0037FI-Hw; Thu, 30 May 2019 08:20:44 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v3 5/8] Introduce run_on_main_thread References: <20190529212916.23721-1-tom@tromey.com> <20190529212916.23721-6-tom@tromey.com> <9f9ea56d-349f-dc19-6201-9241fee71e49@redhat.com> Date: Thu, 30 May 2019 13:20:00 -0000 In-Reply-To: <9f9ea56d-349f-dc19-6201-9241fee71e49@redhat.com> (Pedro Alves's message of "Thu, 30 May 2019 14:12:40 +0100") Message-ID: <87h89cw02c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00685.txt.bz2 Pedro> Can Python's gdb.post_event be built on top of this? Pedro> It would fix that nasty "atomically enough" race in gdbpy_run_events, Pedro> I guess. Yes, and actually I wrote a patch to do this once, but I dropped it from this series because it was unrelated. >> + for (auto &item : local) >> + item (); Pedro> I'd think this should swallow errors when calling Pedro> each item, instead of letting an exception escape and Pedro> discard all other items, since each item call should be Pedro> in principle logically unrelated? Pedro> Maybe we could unit test this code. I wasn't sure how. But for this maybe the callback should be noexcept. Tom