From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31560 invoked by alias); 8 Aug 2019 17:16:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31180 invoked by uid 89); 8 Aug 2019 17:16:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:811 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.149.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Aug 2019 17:16:46 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 878F3AEB43 for ; Thu, 8 Aug 2019 12:16:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vm1thTPOd2PzOvm1thWaRp; Thu, 08 Aug 2019 12:16:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5ofp/OxSKsJwnxOuNbwO5xaqamgzHhvCFWmjFCNKbyg=; b=YRquYtliNYOOXlpEZf87UQ8rd+ /q3mwG25TnX/q/a3+DXLMCq9/TlyHyzlJC6s9XZIfSq9r/JBa7+QGevqV7WOV1tQ7eGUWj96tffsV gHMx7m4yiecy6k+ha0DAGrxuG; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:34968 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hvm1t-002BIb-8b; Thu, 08 Aug 2019 12:16:45 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org, Kevin Buettner Subject: Re: [PATCH][gdb] Fix gdb.dwarf2/varval.exp with -fPIE/-pie References: <20190808124907.GA19791@delia> Date: Thu, 08 Aug 2019 17:16:00 -0000 In-Reply-To: <20190808124907.GA19791@delia> (Tom de Vries's message of "Thu, 8 Aug 2019 14:49:08 +0200") Message-ID: <87h86r60hv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00206.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Thanks for the patch. Tom> + CORE_ADDR baseaddr Tom> + = ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile)); Tom> + struct gdbarch *gdbarch = get_objfile_arch (objfile); Tom> for (const auto &cand_off Tom> : dwarf2_per_objfile->abstract_to_concrete[die->sect_off]) Tom> @@ -23220,6 +23223,8 @@ dwarf2_fetch_die_loc_sect_off (sect_offset sect_off, Tom> CORE_ADDR pc_low, pc_high; Tom> get_scope_pc_bounds (cand->parent, &pc_low, &pc_high, cu); Tom> + pc_low = gdbarch_adjust_dwarf2_addr (gdbarch, pc_low + baseaddr); Tom> + pc_high = gdbarch_adjust_dwarf2_addr (gdbarch, pc_high + baseaddr); Tom> if (pc_low == ((CORE_ADDR) -1) I think this test has to precede the offsetting. Tom