Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org,
	 Pierre Muller <muller@sourceware.org>,
	 Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH][gdb/testsuite] Clean up stale exec in gdb_compile_pascal
Date: Tue, 20 Aug 2019 15:07:00 -0000	[thread overview]
Message-ID: <87h86booxl.fsf@tromey.com> (raw)
In-Reply-To: <20190816162618.GA19652@delia> (Tom de Vries's message of "Fri,	16 Aug 2019 18:26:20 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> 2019-08-16  Tom de Vries  <tdevries@suse.de>

Tom> 	* lib/pascal.exp (gdb_compile_pascal): Remove $destfile before
Tom> 	compilation.

This code is already a little weird, because gpc_compile uses
"remote_exec host", but then the code checks for file existence on the
machine where dejagnu is being run.

However, your patch doesn't make this any worse, so it is ok.
Thanks.

Tom


      reply	other threads:[~2019-08-20 15:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 16:26 Tom de Vries
2019-08-20 15:07 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h86booxl.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=muller@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox