From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55528 invoked by alias); 9 Sep 2019 18:07:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55517 invoked by uid 89); 9 Sep 2019 18:07:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HTo:U*palves X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.45.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Sep 2019 18:07:20 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway20.websitewelcome.com (Postfix) with ESMTP id D7800400D3886 for ; Mon, 9 Sep 2019 12:01:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7O4NilM6KdnCe7O4Ni6lWN; Mon, 09 Sep 2019 13:07:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KK9lMPbXo6nEk8UJH2O3XsVxVNHPx6qV27im386cODw=; b=Zm/KjwMCtzJPsmgkmJELFIXj14 RL5lEnZuNcDfPY7o2uBD7U4KXm+XKWORfegQnKaxB7dLleWaigEGy5njzUziRilLDifN1R4jwXP7f 0C+qGFuIeHqwd95300Upy/9M+; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:52564 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i7O4N-000zP7-70; Mon, 09 Sep 2019 13:07:19 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 04/23] exceptions.c:print_flush: Remove obsolete check References: <20190906232807.6191-1-palves@redhat.com> <20190906232807.6191-5-palves@redhat.com> Date: Mon, 09 Sep 2019 18:07:00 -0000 In-Reply-To: <20190906232807.6191-5-palves@redhat.com> (Pedro Alves's message of "Sat, 7 Sep 2019 00:27:48 +0100") Message-ID: <87h85l9wdm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00135.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Commit 20f0d60db4fb ("Avoid crash when calling warning too early"), Pedro> added a "current_top_target () != NULL" check to Pedro> target_supports_terminal_ours, so this check in exceptions.c is now Pedro> obsolete. Nice find. This looks good to me. Tom