From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.229]) by sourceware.org (Postfix) with ESMTPS id 276313858D35 for ; Fri, 31 Jul 2020 03:17:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 276313858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 5A336BA4 for ; Thu, 30 Jul 2020 22:17:26 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1LXyk7qRDCjCV1LXyk9Dbt; Thu, 30 Jul 2020 22:17:26 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nxJOLF1AzgS1aN9hYVibUGZ19VhWqMYxwoPziUrs+WI=; b=GwR/jxht+Uoql3Uj4rsumoXvap /ECMINI98VuUoO5pM3/vF6F944tldtN/4NTYdBTSc9eVTfGo3AkKaIqGOXU6BOFWW5yqSD/hPL1ht XB7A3yUxBsGxbEcfFE2TSjP3A; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:47536 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1k1LXx-003BT8-RO; Thu, 30 Jul 2020 21:17:26 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 02/23] Don't rely on inferior_ptid in record_full_wait References: <20190906232807.6191-1-palves@redhat.com> <20190906232807.6191-3-palves@redhat.com> X-Attribution: Tom Date: Thu, 30 Jul 2020 21:17:22 -0600 In-Reply-To: <20190906232807.6191-3-palves@redhat.com> (Pedro Alves's message of "Sat, 7 Sep 2019 00:27:46 +0100") Message-ID: <87h7tope4d.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1k1LXx-003BT8-RO X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (bapiya) [174.16.104.48]:47536 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3033.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2020 03:17:29 -0000 >>>>> "Pedro" == Pedro Alves writes: Pedro> The multi-target patch sets inferior_ptid to null_ptid before handling Pedro> a target event, and thus before calling target_wait, in order to catch Pedro> places in target_ops::wait implementations that are incorrectly Pedro> relying on inferior_ptid (which could otherwise be a ptid of a Pedro> different target, for example). That caught this instance in Pedro> record-full.c. I found a few target_ops::wait implementations doing "return inferior_ptid" in error cases. Based on this comment, and the comment for target_wait, I suspect these should actually return minus_one_ptid instead. I've appended the patch so you can see what it looks like. I haven't tried it at all. Does this seem correct? Tom diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c index ae0b0f7ff0d..2cae87023f9 100644 --- a/gdb/inf-ptrace.c +++ b/gdb/inf-ptrace.c @@ -343,7 +343,7 @@ inf_ptrace_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus, /* Claim it exited with unknown signal. */ ourstatus->kind = TARGET_WAITKIND_SIGNALLED; ourstatus->value.sig = GDB_SIGNAL_UNKNOWN; - return inferior_ptid; + return minus_one_ptid; } /* Ignore terminated detached child processes. */ diff --git a/gdb/obsd-nat.c b/gdb/obsd-nat.c index 6667a0add7f..5414adec051 100644 --- a/gdb/obsd-nat.c +++ b/gdb/obsd-nat.c @@ -101,7 +101,7 @@ obsd_nat_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus, /* Claim it exited with unknown signal. */ ourstatus->kind = TARGET_WAITKIND_SIGNALLED; ourstatus->value.sig = GDB_SIGNAL_UNKNOWN; - return inferior_ptid; + return minus_one_ptid; } /* Ignore terminated detached child processes. */ diff --git a/gdb/rs6000-nat.c b/gdb/rs6000-nat.c index 654e06e3e4b..f73919f055c 100644 --- a/gdb/rs6000-nat.c +++ b/gdb/rs6000-nat.c @@ -522,7 +522,7 @@ rs6000_nat_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus, /* Claim it exited with unknown signal. */ ourstatus->kind = TARGET_WAITKIND_SIGNALLED; ourstatus->value.sig = GDB_SIGNAL_UNKNOWN; - return inferior_ptid; + return minus_one_ptid; } /* Ignore terminated detached child processes. */