From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 252tBsuUkV+jPgAAWB0awg (envelope-from ) for ; Thu, 22 Oct 2020 10:18:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 0D6A21E89B; Thu, 22 Oct 2020 10:18:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 53A101E552 for ; Thu, 22 Oct 2020 10:18:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C317E386F42A; Thu, 22 Oct 2020 14:18:49 +0000 (GMT) Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.196.18]) by sourceware.org (Postfix) with ESMTPS id 49882384C002 for ; Thu, 22 Oct 2020 14:18:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 49882384C002 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 9D79C4325 for ; Thu, 22 Oct 2020 09:18:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id VbQTkRQgRPiqfVbQTkW6Ol; Thu, 22 Oct 2020 09:18:45 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1x+A75q1tGq4stav8tI1+DRGhZee1b4yv009HpPP9Pg=; b=UAH1G82MIsrlrjVW1MptjjVRFe 1Abfl4OdBQhEDnTgzqgcLhDhrHCJVpvPTSBIf+6w1jR4r2orMgv9OlaxfvrVhXhcixMq3zmGIlBLw aP5ahJ4Fw9yNLHHnoQJVaJP//; Received: from 75-166-102-113.hlrn.qwest.net ([75.166.102.113]:58582 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kVbQT-0013nc-AW; Thu, 22 Oct 2020 08:18:45 -0600 From: Tom Tromey To: Simon Marchi Subject: Re: [PATCH v2] gdb/dwarf: fix reading subprogram with DW_AT_specification (PR gdb/26693) References: <20201020165055.93142-1-simon.marchi@polymtl.ca> <878sbzgvk0.fsf@tromey.com> X-Attribution: Tom Date: Thu, 22 Oct 2020 08:18:43 -0600 In-Reply-To: (Simon Marchi's message of "Wed, 21 Oct 2020 22:37:07 -0400") Message-ID: <87h7qmcpj0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.102.113 X-Source-L: No X-Exim-ID: 1kVbQT-0013nc-AW X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-102-113.hlrn.qwest.net (murgatroyd) [75.166.102.113]:58582 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , Simon Marchi via Gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >> gdb currently goes through a lot of work to support DWARF like this, but >> I wish it didn't have to. It complicates the DWARF reader -- but IIRC >> both gcc and clang just emit specializations with names like >> "apply". So, I wonder if we could drop support for this at some >> point. Simon> The object that contained this kind of DWARF, that made GDB crash, was Simon> compiled with ICC. So unless we decide to drop support for ICC, I don't Simon> think we can get rid of it any time soon. Well, we could support it in a more limited way - like, these functions would still appear but without template parameters in their names. We could try to get a clarification from DWARF as to whether icc or gcc/clang are correct here, then file bug(s) against the compiler. Simon> I would write this, does that sound good? Simon> /* Load the DIEs associated with PER_CU into memory. Simon> In some cases, the caller, while reading partial symbols, will need to load Simon> the full symbols for the CU for some reason. It will already have a Simon> dwarf2_cu object for THIS_CU and pass it as EXISTING_CU, so it can be re-used Simon> rather than creating a new one. */ Looks great, thank you. Tom