From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NsG0GjuYpV/GGQAAWB0awg (envelope-from ) for ; Fri, 06 Nov 2020 13:38:51 -0500 Received: by simark.ca (Postfix, from userid 112) id 613CA1F08B; Fri, 6 Nov 2020 13:38:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DDA731E58E for ; Fri, 6 Nov 2020 13:38:50 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5B9203860C36; Fri, 6 Nov 2020 18:38:50 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.145.82]) by sourceware.org (Postfix) with ESMTPS id 382B73860C36 for ; Fri, 6 Nov 2020 18:38:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 382B73860C36 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 87EBA247D7 for ; Fri, 6 Nov 2020 12:38:45 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id b6dJkvxOWiQiZb6dJkj1VO; Fri, 06 Nov 2020 12:38:45 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dQqR/wwydbrj95PTRTYVZTWhlYojptQMgQkg+uK7DLs=; b=EwxJxbme7+NcYLp5CVmBXUec12 5JCpSh29MgcYQEPZ2GaeJ2PI2R9r8vZppA8HdPymJUiVCoNfy5Y4Ed4fP09xbWTmJ1xpfIcK0carB nKFroBLTy0PJxW89arpPoQrxh; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:46290 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kb6dJ-0038Xf-1m; Fri, 06 Nov 2020 11:38:45 -0700 From: Tom Tromey To: Andrew Burgess Subject: Re: [PATCH] gdb: fix debug expression dumping of function call expressions References: <20201106181859.437662-1-andrew.burgess@embecosm.com> X-Attribution: Tom Date: Fri, 06 Nov 2020 11:38:43 -0700 In-Reply-To: <20201106181859.437662-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Fri, 6 Nov 2020 18:18:59 +0000") Message-ID: <87h7q2ib4c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kb6dJ-0038Xf-1m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:46290 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Andrew> In this commit I have cleaned up all of the debug-expr.exp files a Andrew> little, there was a helper function that had clearly been copied into Andrew> each file, this is now moved into lib/gdb.exp. Andrew> I've added a gdb.fortran/debug-expr.exp test file, and extended Andrew> gdb.base/debug-expr.exp to cover the function call case. This looks good to me. Thank you for doing this. Andrew> - (*pos) += 2; Andrew> unsigned nargs = longest_to_int (exp->elts[*pos].longconst); Andrew> + (*pos) += 2; A couple times I have toyed with rewriting struct expression to not be so incredibly obscure. However, this is a difficult project :(. There are a lot of places to change and I haven't come up with an approach better than "one enormous patch". Tom