From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id h6wNBMM4jGDgagAAWB0awg (envelope-from ) for ; Fri, 30 Apr 2021 13:05:07 -0400 Received: by simark.ca (Postfix, from userid 112) id 512B91F11C; Fri, 30 Apr 2021 13:05:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 31C3B1E813 for ; Fri, 30 Apr 2021 13:05:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC4893857802; Fri, 30 Apr 2021 17:05:04 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.224]) by sourceware.org (Postfix) with ESMTPS id 5D25B3857802 for ; Fri, 30 Apr 2021 17:05:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5D25B3857802 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id C21E622E0A for ; Fri, 30 Apr 2021 12:04:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cWZXloYWdL7DmcWZXlnqF4; Fri, 30 Apr 2021 12:04:59 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9XDi5Y4fzzzM/+tNlhheQ+LnTiGwciE0FHQCly8Z9mo=; b=d2q4dkZb3VCdB+ipcQEHnLZ/JC 3qjveARvkI1dLp45CBjrjpvGqPVsEEPO7QdVrHiaFGhWnVuhpDmdnRAHHInbb/BzUO+QXssPWJpqv elkI0HpVoxeanD3NF+rZ1plkI; Received: from 97-122-70-176.hlrn.qwest.net ([97.122.70.176]:51970 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lcWZX-000UnF-CY; Fri, 30 Apr 2021 11:04:59 -0600 From: Tom Tromey To: Lancelot SIX via Gdb-patches Subject: Re: Proposal: format GDB Python files with black References: <20210426224012.i5gaiqjbkjsmre4k@gwenhwyvar> X-Attribution: Tom Date: Fri, 30 Apr 2021 11:04:58 -0600 In-Reply-To: <20210426224012.i5gaiqjbkjsmre4k@gwenhwyvar> (Lancelot SIX via Gdb-patches's message of "Mon, 26 Apr 2021 23:40:12 +0100") Message-ID: <87h7jnwvnp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.176 X-Source-L: No X-Exim-ID: 1lcWZX-000UnF-CY X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-176.hlrn.qwest.net (murgatroyd) [97.122.70.176]:51970 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lancelot SIX Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Lancelot" =3D=3D Lancelot SIX via Gdb-patches writes: Lancelot> Another option can be to use 'black' to Lancelot> help format the code and 'pycodestyle'[3] to do the automated che= cks, Lancelot> but I am not sure this is the way you want to go to, introducing = more Lancelot> and more tools. Doing some kind of checking like this would be good as well. We've used pycodestyle internally a bit, but recently (-ish) moved to flake8. I don't know why we made the switch or which static checker is preferable, though. Lancelot> I=E2=80=99d also like to point out that by default, 'black' will = use 88 char Lancelot> long lines[4], which is not compliant with the PEP8[5], which is,= as you Lancelot> pointed out[1], referenced in GDB's wiki[6]. Either the tool's Lancelot> configuration or the standard can be adjusted, depending on the Lancelot> maintainers preferences. We only really chose PEP8 because it existed; not out of some deeper liking for it or anything like that. So personally I'm fine with just switching to a tool. Tom