From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id C0tsDXDYr2AlQwAAWB0awg (envelope-from ) for ; Thu, 27 May 2021 13:35:44 -0400 Received: by simark.ca (Postfix, from userid 112) id 289C71F11C; Thu, 27 May 2021 13:35:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3FC501E01F for ; Thu, 27 May 2021 13:35:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D1043858024; Thu, 27 May 2021 17:35:42 +0000 (GMT) Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.200.11]) by sourceware.org (Postfix) with ESMTPS id C9D363858024 for ; Thu, 27 May 2021 17:35:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C9D363858024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 18853400C9DF0 for ; Thu, 27 May 2021 12:35:35 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id mJuxlSLGpnrr4mJuxlKKlS; Thu, 27 May 2021 12:35:35 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kDwJnaeS2c9nLesMVf1tyFshi7vANji07P68Tiy61sc=; b=OlgJzWqF4/r6lfzhVZ+bsQTzjR U3Ful9idogW/lAH1Lr5ES6bpg3dF/hZBYm2v/eNd1/rsgAQ6qVi8+WzKcrQfOt9cCu86mLfG/9wgD pz0SR0fBcKeDzQNIgtyN48+SC; Received: from 75-166-146-111.hlrn.qwest.net ([75.166.146.111]:55126 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lmJux-001AjX-3C; Thu, 27 May 2021 11:35:35 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH 2/9] gdb: add all_breakpoints_safe function References: <20210527153558.3016335-1-simon.marchi@polymtl.ca> <20210527153558.3016335-3-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 27 May 2021 11:35:34 -0600 In-Reply-To: <20210527153558.3016335-3-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Thu, 27 May 2021 11:35:51 -0400") Message-ID: <87h7iot6zd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.146.111 X-Source-L: No X-Exim-ID: 1lmJux-001AjX-3C X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-146-111.hlrn.qwest.net (murgatroyd) [75.166.146.111]:55126 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> @@ -3143,9 +3154,7 @@ remove_breakpoints (void) Simon> static void Simon> remove_threaded_breakpoints (struct thread_info *tp, int silent) Simon> { Simon> - struct breakpoint *b, *b_tmp; Simon> - Simon> - ALL_BREAKPOINTS_SAFE (b, b_tmp) Simon> + for (breakpoint *b : all_breakpoints ()) Simon> { Simon> if (b->thread == tp->global_num && user_breakpoint_p (b)) Simon> { I had to go look, but this one is ok to convert to the non-safe iterator, as it doesn't modify the collection in the loop. Tom