From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HpZnHJb62GBEewAAWB0awg (envelope-from ) for ; Sun, 27 Jun 2021 18:24:22 -0400 Received: by simark.ca (Postfix, from userid 112) id 648241F1F2; Sun, 27 Jun 2021 18:24:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 84F771E01F for ; Sun, 27 Jun 2021 18:24:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9F5013839C46 for ; Sun, 27 Jun 2021 22:24:20 +0000 (GMT) Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.144.80]) by sourceware.org (Postfix) with ESMTPS id 117313857C73 for ; Sun, 27 Jun 2021 22:24:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 117313857C73 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 7B6D84C2F8 for ; Sun, 27 Jun 2021 17:24:07 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xdCBloIgG7sOixdCBlqiHY; Sun, 27 Jun 2021 17:24:07 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=f27lRK7nvHz1KlZp95BkgLgxqrPv2pVTtqkkiLAPuU8=; b=ND0Mn9n4amV4NxF6907FZCE2YB 2zISTz5AL+DJFEyYYdZMiK/O57Klpfel9WpLdDMzcthdO2/R79UWL6A1QeopeMgtaHiRc65OVBq+1 bRNlZ8VE2+SULLNVtinNXB0gP; Received: from 71-211-145-10.hlrn.qwest.net ([71.211.145.10]:39356 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lxdCB-0012OQ-7I; Sun, 27 Jun 2021 16:24:07 -0600 From: Tom Tromey To: Tom de Vries Subject: Re: [RFC][gdb/symtab] Lazy expansion of full symbol table References: <20210614093908.GA22709@delia> <87pmwoxj3j.fsf@tromey.com> <533bf7e4-d96c-a6b7-8c37-a4141ebdc761@suse.de> <87im2fxnr7.fsf@tromey.com> <87bl83ykd9.fsf@tromey.com> <87tulsw17w.fsf@tromey.com> <25c649a5-6019-3500-7486-e909bac56f92@suse.de> X-Attribution: Tom Date: Sun, 27 Jun 2021 16:24:06 -0600 In-Reply-To: <25c649a5-6019-3500-7486-e909bac56f92@suse.de> (Tom de Vries's message of "Mon, 21 Jun 2021 11:18:33 +0200") Message-ID: <87h7hjvtdl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.145.10 X-Source-L: No X-Exim-ID: 1lxdCB-0012OQ-7I X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-145-10.hlrn.qwest.net (localhost.localdomain) [71.211.145.10]:39356 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> I managed to fix that using this patch: Tom> ... Tom> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c Tom> index 265ebee1de8..f98acfa33ed 100644 Tom> --- a/gdb/dwarf2/read.c Tom> +++ b/gdb/dwarf2/read.c Tom> @@ -7204,7 +7204,8 @@ skip_one_die (const struct die_reader_specs Tom> *reader, const gdb_b Tom> yte *info_ptr, Tom> /* We only handle DW_FORM_ref4 here. */ Tom> const gdb_byte *sibling_data = info_ptr + abbrev->sibling_offset; Tom> unsigned int offset = read_4_bytes (abfd, sibling_data); Tom> - const gdb_byte *sibling_ptr = buffer + offset; Tom> + const gdb_byte *sibling_ptr Tom> + = buffer + to_underlying (cu->header.sect_off) + offset; Tom> if (sibling_ptr >= info_ptr && sibling_ptr < reader->buffer_end) Tom> return sibling_ptr; Tom> /* Fall through to the slow way. */ Tom> ... Tom> The DW_FORM_ref4 offset is relative to the start of the CU, but buffer Tom> points to the start of .debug_info. Thanks. I think I copied this without realizing or remembering that read_attribute_value adds in the section offset automatically. Tom